Presentation does not show error msg if don flow is cancelled |
||||
Issue descriptionChrome Version: 61.0.3143.0 OS: Android N (Pixel) VR Core: 1.6.160172134 Daydream: 1.6.170509043 Does not happen on 60.0.3112.43 What steps will reproduce the problem? Set Daydream as headset (1) go to https://webvr.info/samples/03-vr-presentation.html and press enter VR button (2) hold phone horizontally until don flow prompts the user to sync the controller (3) Swipe in from right side of screen and press system back button What is the expected result? an error msg is displayed on screen What happens instead? no error msg is displayed (See screenshots)
,
Jun 28 2017
Yes, this is related to the DON flow change. Working on a fix now, but this is turning out to be extremely annoying.
,
Jun 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcc6da1cac65953c78288211444ce8e83c188999 commit dcc6da1cac65953c78288211444ce8e83c188999 Author: Michael Thiessen <mthiesse@chromium.org> Date: Fri Jun 30 21:18:44 2017 VR: Delay setting present result until DON flow completes. This CL does two main things: 1. It delays telling the webVR page the presentation result until the DON flow is completed. 2. It keeps Chrome in VR when we're going through the DON flow for both sanity and smoothness reasons (we now resume ~instantly after the DON flow). This CL inadvertently exposed a focus issue around presentation, which is fixed by making sure the VrDisplay isn't blurred due to focus while presenting. It also drive-by fixes some possible races in starting/ending presentation, making sure bindings are closed appropriately. Bug: 737259 , 737656 Change-Id: I97892617a75a597effd70dbadbf53547a2578825 Reviewed-on: https://chromium-review.googlesource.com/553558 Reviewed-by: Brandon Jones <bajones@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#483815} [modify] https://crrev.com/dcc6da1cac65953c78288211444ce8e83c188999/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/dcc6da1cac65953c78288211444ce8e83c188999/chrome/browser/android/vr_shell/vr_shell_delegate.cc [modify] https://crrev.com/dcc6da1cac65953c78288211444ce8e83c188999/chrome/browser/android/vr_shell/vr_shell_gl.cc [modify] https://crrev.com/dcc6da1cac65953c78288211444ce8e83c188999/chrome/browser/android/vr_shell/vr_shell_gl.h [modify] https://crrev.com/dcc6da1cac65953c78288211444ce8e83c188999/chrome/test/data/android/webvr_instrumentation/html/test_presentation_locks_focus.html [modify] https://crrev.com/dcc6da1cac65953c78288211444ce8e83c188999/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
,
Jul 7 2017
Is this fixed now?
,
Jul 7 2017
Should be fixed.
,
Jul 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ddorwin@chromium.org
, Jun 28 2017