New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737649 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Navigating to chrome://proximity-auth crashes Chrome

Project Member Reported by hansberry@chromium.org, Jun 28 2017

Issue description

Backtrace from gdb:

#0  proximity_auth::ProximityAuthWebUIHandler::ExternalDeviceInfoToDictionary(cryptauth::ExternalDeviceInfo const&) ()
    at /usr/local/google/home/hansberry/chromium/.cros_cache/chrome-sdk/tarballs/veyron_minnie+9649.0.0+target_toolchain/usr/bin/../lib/gcc/armv7a-cros-linux-gnueabi/4.9.x/include/g++-v4/bits/basic_string.h:293

#1  0x3a48842a in proximity_auth::ProximityAuthWebUIHandler::GetRemoteDevicesList() () at ../../components/proximity_auth/webui/proximity_auth_webui_handler.cc:471

#2  0x3a4873ca in proximity_auth::ProximityAuthWebUIHandler::GetLocalState(base::ListValue const*) () at ../../components/proximity_auth/webui/proximity_auth_webui_handler.cc:422

#3  0x37ae87c0 in content::WebUIImpl::ProcessWebUIMessage(GURL const&, std::string const&, base::ListValue const&) () at ../../base/callback.h:80
#4  0x37ae7c56 in bool IPC::MessageT<ViewHostMsg_WebUISend_Meta, std::tuple<GURL, std::string, base::ListValue>, void>::Dispatch<content::WebUIImpl, content::WebUIImpl, void, void (content::WebUIImpl::*)(GURL const&, std::string const&, base::ListValue const&)>(IPC::Message const*, content::WebUIImpl*, content::WebUIImpl*, void*, void (content::WebUIImpl::*)(GURL const&, std::string const&, base::ListValue const&)) () at ../../base/tuple.h:77
#5  0x37ae7b3e in content::WebUIImpl::OnMessageReceived(IPC::Message const&) () at ../../content/browser/webui/web_ui_impl.cc:98
#6  0x37ac73ea in content::WebContentsImpl::OnMessageReceived(content::RenderViewHostImpl*, IPC::Message const&) () at ../../content/browser/web_contents/web_contents_impl.cc:752
#7  0x37a25412 in content::RenderViewHostImpl::OnMessageReceived(IPC::Message const&) () at ../../content/browser/renderer_host/render_view_host_impl.cc:713
#8  0x37a28814 in content::RenderWidgetHostImpl::OnMessageReceived(IPC::Message const&) () at ../../content/browser/renderer_host/render_widget_host_impl.cc:543
#9  0x37a1b410 in content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&) () at ../../content/browser/renderer_host/render_process_host_impl.cc:2493
#10 0x391f4174 in IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) () at ../../ipc/ipc_channel_proxy.cc:329
#11 0x389d5f70 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) () at ../../base/callback.h:91
#12 0x38979b40 in base::MessageLoop::RunTask(base::PendingTask*) () at ../../base/message_loop/message_loop.cc:422
#13 0x38979e1c in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) () at ../../base/message_loop/message_loop.cc:433
#14 0x3897a0c0 in base::MessageLoop::DoWork() () at ../../base/message_loop/message_loop.cc:540
#15 0x3897b3f8 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) () at ../../base/message_loop/message_pump_libevent.cc:219
#16 0x38994458 in base::RunLoop::Run() () at ../../base/run_loop.cc:111
#17 0x386db7ea in ChromeBrowserMainParts::MainMessageLoopRun(int*) () at ../../chrome/browser/chrome_browser_main.cc:1950
#18 0x378342f0 in content::BrowserMainLoop::RunMainMessageLoopParts() () at ../../content/browser/browser_main_loop.cc:1145
#19 0x3783618c in content::BrowserMainRunnerImpl::Run() () at ../../content/browser/browser_main_runner.cc:142
#20 0x37830c52 in content::BrowserMain(content::MainFunctionParams const&) () at ../../content/browser/browser_main.cc:46
#21 0x386b98c0 in content::ContentMainRunnerImpl::Run() () at ../../content/app/content_main_runner.cc:704
#22 0x386d3490 in service_manager::Main(service_manager::MainParams const&) () at ../../services/service_manager/embedder/main.cc:469
#23 0x386b8c0c in content::ContentMain(content::ContentMainParams const&) () at ../../content/app/content_main.cc:19
#24 0x3745a0de in ChromeMain () at ../../chrome/app/chrome_main.cc:125
#25 0xaae7d8b8 in __libc_start_main (main=0x0, argc=-1096715384, argv=0x0, init=<optimized out>, fini=0x3be81f8d <__libc_csu_fini>, rtld_fini=0xab4f4f41 <_dl_fini>, stack_end=0xbea174e4) at libc-start.c:289
#26 0x37459f80 in _start ()

 
I can't reproduce this. Can you figure out exactly which line is causing the crash and dig a bit more? Thanks.
I had suspected that this issue was caused by corrupted data due to another crash, but after reimaging my Chromebook and signing in with the same account, Im seeing this same error. 

Strangely, I don't see this error on my other test account (which also has a lot of devices on it).

It seems something changed recently in either the way ExternalDeviceInfos were stored or the way they're read in ProximityAuthWebUIHandler. I'll continue digging.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c3996033bfbba55546e24e8845d8f76e271ff27

commit 7c3996033bfbba55546e24e8845d8f76e271ff27
Author: hansberry <hansberry@chromium.org>
Date: Thu Jun 29 18:29:32 2017

ProximityAuthWebUIHandler: use the same ExternalDeviceInfo vector across iterator usages.

This code was previously causing a crash because 3 separate vectors were being created, and iterators from each were being compared to each other. It seems that this went undetected for so long because people usually have 1 or 0 unlock keys -- this explains why the bug attached was observed on some accounts but not others.

BUG= 737649 

Review-Url: https://codereview.chromium.org/2962173002
Cr-Commit-Position: refs/heads/master@{#483433}

[modify] https://crrev.com/7c3996033bfbba55546e24e8845d8f76e271ff27/components/proximity_auth/webui/proximity_auth_webui_handler.cc

Status: Fixed (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/661cfff40b630b1c27e488e0d944f0ec549d78bf

commit 661cfff40b630b1c27e488e0d944f0ec549d78bf
Author: Robert Phillips <robertphillips@google.com>
Date: Wed Oct 25 13:26:23 2017

Remove flaky Mac 10.11 layout test images

The rebaseline CL:

https://chromium-review.googlesource.com/c/chromium/src/+/735755 (Remove suppressions for Skia rolls)

added new Mac 10.11 images for the following layout tests:

mac-mac10.11/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
mac-mac10.11/virtual/gpu-rasterization/images/color-profile-mask-image-svg-expected.png

but they immediately began failing on the bots and were suppressed in:

https://chromium-review.googlesource.com/c/chromium/src/+/737649 (sheriff: Suppress failing tests)

This CL removes the images and the suppressions.

TBR=fmalita@chromium.org

Bug:  737649 
Change-Id: I1ba9d0cccdb52bcc499a07ceec46012a70d6241b
Reviewed-on: https://chromium-review.googlesource.com/737855
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#511435}
[modify] https://crrev.com/661cfff40b630b1c27e488e0d944f0ec549d78bf/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/8e4cfe0345035e34e327b47a916ea1e78e2105d8/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[delete] https://crrev.com/8e4cfe0345035e34e327b47a916ea1e78e2105d8/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu-rasterization/images/color-profile-mask-image-svg-expected.png

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment