New issue
Advanced search Search tips

Issue 737646 link

Starred by 4 users
Status: Available
Owner: ----
Cc:
aga...@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Block CL submission on unresolved comments

Project Member Reported by kylec...@chromium.org, Jun 28 2017 
It would be nice if Gerrit blocked CL submission if there were unresolved comments. It provides a couple benefits:

1. It prevents the author from missing comments on old patches.
2. It gives reviewers more confidence the author is going to fix the issues raised in comments. This is helpful with ""+1 Code Review with nits" situations.
3. It would be consistent with other Google code review tools.
4. Gerrit seems to support this out of the box.

Comment 1 by aga...@chromium.org, Jun 28 2017 

Thanks for filing the bug!

Link to documentation for gerrit's native support for this, for future reference:  https://gerrit-review.googlesource.com/Documentation/prolog-cookbook.html#_example_16_make_change_submittable_if_all_comments_have_been_resolved

Comment 2 by aga...@chromium.org, Jan 3 2018

Labels: -Milestone-Afterglow
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.

Comment 3 by backer@chromium.org, May 10 2018 

Often comments go unresolved because they are unseen without any malicious intent. This will help prevent things from falling through the cracks and reduce friction between developers.

Comment 4 by backer@chromium.org, May 10 2018

Labels: -Pri-3 Pri-2
@agable: Sounds like this would be little effort for tangible impact. Maybe P2?
►

Sign in to add a comment