New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737643 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Disable Feature-Policy HTTP header for Chrome M60

Project Member Reported by iclell...@chromium.org, Jun 28 2017

Issue description

The syntax of the "Feature-Policy" HTTP header is under discussion at the moment, and may change radically, in a backwards-incompatible way. Given that there is essentially no usage of the header, it seems prudent to disable it for the M60 release, and reinstate it afterwards, once the spec has stabilized.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b78206e4c97d23230ccfd819885e8001a8bdc795

commit b78206e4c97d23230ccfd819885e8001a8bdc795
Author: iclelland <iclelland@chromium.org>
Date: Fri Jun 30 16:37:05 2017

Disable Feature-Policy HTTP Header

This is a temporary measure while the header syntax is being debated, to ensure that a format which may not be the eventual standard doesn't become relied upon by sites, and accidentally become a permanent part of the web platform.

BUG= 737643 

Review-Url: https://codereview.chromium.org/2936293002
Cr-Commit-Position: refs/heads/master@{#483731}

[modify] https://crrev.com/b78206e4c97d23230ccfd819885e8001a8bdc795/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/b78206e4c97d23230ccfd819885e8001a8bdc795/third_party/WebKit/Source/core/loader/DocumentLoader.cpp

Labels: Merge-Request-60
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 4 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Started)
Fixed landed on trunk, and tested in Canary; still requires merge to M60 branch
Labels: -Merge-Review-60 Merge-Approved-60
Approving merge to M60. 
Thanks!
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 7 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/360e15ec26cec7d5823421707839e44958678c8b

commit 360e15ec26cec7d5823421707839e44958678c8b
Author: Ian Clelland <iclelland@google.com>
Date: Fri Jul 07 15:31:33 2017

Disable Feature-Policy HTTP Header

This is a temporary measure while the header syntax is being debated, to ensure
that a format which may not be the eventual standard doesn't become relied upon
by sites, and accidentally become a permanent part of the web platform.

BUG= 737643 
TBR=iclelland@chromium.org

(cherry picked from commit b78206e4c97d23230ccfd819885e8001a8bdc795)

Review-Url: https://codereview.chromium.org/2936293002
Cr-Original-Commit-Position: refs/heads/master@{#483731}
Change-Id: I5f1ac7446461ddcf1f53829ff7f87e804a9ce961
Reviewed-on: https://chromium-review.googlesource.com/563438
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#540}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/360e15ec26cec7d5823421707839e44958678c8b/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/360e15ec26cec7d5823421707839e44958678c8b/third_party/WebKit/Source/core/loader/DocumentLoader.cpp

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ec7521db9dd9304049040de049f3c6819afc8b1

commit 6ec7521db9dd9304049040de049f3c6819afc8b1
Author: Ian Clelland <iclelland@google.com>
Date: Fri Jul 07 17:00:00 2017

Fix Disable Feature-Policy HTTP Header for M60

This fixes an issue with commit 360e15ec26cec7d5823421707839e44958678c8b
where the wrong capitalization of the generated RuntimeEnabledFeatures
method was used.

Bug:  737643 
Change-Id: I74bb537a33a2b28432470b66c2ff76828f93e563
TBR: rbyers@chromium.org
NOTRY: true
NOPRESUBMIT: true
Reviewed-on: https://chromium-review.googlesource.com/563836
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#542}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/6ec7521db9dd9304049040de049f3c6819afc8b1/third_party/WebKit/Source/core/loader/DocumentLoader.cpp

Sign in to add a comment