[stacked tabs] Improper stacking logic when tabs are added via 'open link in new tab' |
|||
Issue descriptionObserved on 61.0.3138.0 canary, though this is almost certainly a longstanding issue, even predating the M-50 material design tab strip refresh. Steps to reproduce: 1. Enter stacked tab mode. 2. Within a web page, longpress a link and select "open link in new tab". 3. Repeat step 2. Doing this results in a stack forming to the left of the active tab, which is incorrect.
,
Jun 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7aa4e8bf36efda4db554567ffc5b13f14540601e commit 7aa4e8bf36efda4db554567ffc5b13f14540601e Author: tdanderson <tdanderson@chromium.org> Date: Thu Jun 29 16:05:16 2017 [stacked tabs] Fix stacking logic with 'open link in new tab' Currently when in stacked tab mode, using 'open link in new tab' can result in a stack forming to the left of the active tab. Prevent this from happening, and also do not adjust the position of the active tab to the left unless necessary in order to show all tabs between the active tab and the newly-opened tab (inclusive). BUG= 737639 TEST=StackedTabStripLayoutTest.AddTab Review-Url: https://codereview.chromium.org/2963023002 Cr-Commit-Position: refs/heads/master@{#483375} [modify] https://crrev.com/7aa4e8bf36efda4db554567ffc5b13f14540601e/chrome/browser/ui/views/tabs/stacked_tab_strip_layout.cc [modify] https://crrev.com/7aa4e8bf36efda4db554567ffc5b13f14540601e/chrome/browser/ui/views/tabs/stacked_tab_strip_layout.h [modify] https://crrev.com/7aa4e8bf36efda4db554567ffc5b13f14540601e/chrome/browser/ui/views/tabs/stacked_tab_strip_layout_unittest.cc
,
Jun 29 2017
,
Jan 22 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tdander...@chromium.org
, Jun 28 2017