Issue metadata
Sign in to add a comment
|
TypeScript 2.4 upgrade breaks luci-go presubmit and blocks CQ |
||||||||||||||||||||||
Issue descriptionPresubmit run from unrelated change: https://luci-logdog.appspot.com/v/?s=infra%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8975599736804709232%2F%2B%2Fsteps%2Fpresubmit%2F0%2Fstdout I'm not sure how this is possible because I thought we pinned all dependencies, but it looks like we're using semvers instead, like a bunch of chumps :(. I'm disabling this presubmit test until it can be fixed.
,
Jun 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/2ae56cd555233728c302e9a67d229fc35aaf007f commit 2ae56cd555233728c302e9a67d229fc35aaf007f Author: iannucci <iannucci@chromium.org> Date: Wed Jun 28 17:54:07 2017 Change typescript pin to ~2.3. This should unblock CQ, but should also prevent us from upgrading to 2.4, which has some stricter checks that find bugs in logdog. R=dnj@chromium.org, vadimsh@chromium.org BUG= 737631 Review-Url: https://codereview.chromium.org/2958313002 [modify] https://crrev.com/2ae56cd555233728c302e9a67d229fc35aaf007f/web/package.json
,
Jun 29 2017
,
Jul 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/778ac0b55880b89da16bcddae98765f45d08d3c7 commit 778ac0b55880b89da16bcddae98765f45d08d3c7 Author: dnj <dnj@chromium.org> Date: Sat Jul 01 15:24:39 2017 [web] Update packages, use TS 2.4 Update web to use TypeScript 2.4, and fix some minor bugs that are now detected. Update some package versions to remove some deprecation warnings. BUG= chromium:737631 TEST=local Review-Url: https://codereview.chromium.org/2969643003 [modify] https://crrev.com/778ac0b55880b89da16bcddae98765f45d08d3c7/web/apps/gulp-common.js [modify] https://crrev.com/778ac0b55880b89da16bcddae98765f45d08d3c7/web/inc/logdog-stream-view/model.ts [modify] https://crrev.com/778ac0b55880b89da16bcddae98765f45d08d3c7/web/inc/luci-operation/operation.ts [modify] https://crrev.com/778ac0b55880b89da16bcddae98765f45d08d3c7/web/package.json [modify] https://crrev.com/778ac0b55880b89da16bcddae98765f45d08d3c7/web/web.py
,
Jul 1 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by iannucci@chromium.org
, Jun 28 2017