New issue
Advanced search Search tips

Issue 737623 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

11.2%-11.6% regression in blink_perf.layout at 482683:482759

Project Member Reported by tdres...@chromium.org, Jun 28 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 29 2017

Cc: wangxianzhu@chromium.org
Owner: wangxianzhu@chromium.org

=== Auto-CCing suspected CL author wangxianzhu@chromium.org ===

Hi wangxianzhu@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Xianzhu Wang
  Commit : 2381016a46e881351c34f7b7c2e6692565222132
  Date   : Tue Jun 27 18:43:07 2017
  Subject: Add WritingModeUtils.h to convert logical/physical directions

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : blink_perf.layout
  Metric       : large-table-with-collapsed-borders-and-colspans-wider-than-table/large-table-with-collapsed-borders-and-colspans-wider-than-table
  Change       : 7.86% | 1502.52283333 -> 1620.62883333

Revision             Result                  N
chromium@482682      1502.52 +- 15.3897      6      good
chromium@482683      2664.01 +- 1757.2       6      bad       <--
chromium@482684      1654.77 +- 16.5105      6      bad
chromium@482685      1651.08 +- 19.5339      6      bad
chromium@482687      1627.36 +- 18.9641      6      bad
chromium@482692      1621.17 +- 15.3221      6      bad
chromium@482702      1623.46 +- 25.9069      6      bad
chromium@482721      1630.71 +- 13.397       6      bad
chromium@482759      1620.63 +- 15.8416      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.layout

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8975524707192208880

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5100516964564992


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Components: Blink>Layout>Table

Comment 6 by e...@chromium.org, Jun 30 2017

Status: Assigned (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/013be9bae99c12145f811bdb512cdd624426ac5b

commit 013be9bae99c12145f811bdb512cdd624426ac5b
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Jun 30 22:18:01 2017

Improve performance of LayoutTableCell::CollapsedBorderXXXHalfXXX()

Refactored code to allow the compiler to eliminate unused parameter
evaluations for LogicalToPhysical template.

BUG= 737623 

Change-Id: Iafa1e40ee762041671cf9c430b98c95217d2eb49
Reviewed-on: https://chromium-review.googlesource.com/558193
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483842}
[modify] https://crrev.com/013be9bae99c12145f811bdb512cdd624426ac5b/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/013be9bae99c12145f811bdb512cdd624426ac5b/third_party/WebKit/Source/core/layout/LayoutTableCell.h
[modify] https://crrev.com/013be9bae99c12145f811bdb512cdd624426ac5b/third_party/WebKit/Source/core/layout/LayoutTableCellTest.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Jul 29 2017

Cc: rmcilroy@chromium.org vmi...@chromium.org
 Issue 739300  has been merged into this issue.
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Jul 29 2017

Cc: lizeb@chromium.org
 Issue 739301  has been merged into this issue.

Sign in to add a comment