Add regression test for 737259 |
||||
Issue descriptionCurrently, all our tests run with the option to skip the DON flow enabled, meaning that we can't catch bugs where we're doing things before the DON flow completes. Adding the tests themselves will be pretty easy, although it will also require: 1. Setting the tests to not be run when the DON flow is skipped (unable to check from within Chrome AFAIK, so probably have to rely on a command line flag being passed to the test) 2. Adding another invocation of chrome_public_test_vr_apk to the bots that runs with the DON flow enabled and only runs the tests that expect it to be.
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13f9a4aaceff4a745aff017d2de734e091086afc commit 13f9a4aaceff4a745aff017d2de734e091086afc Author: bsheedy <bsheedy@chromium.org> Date: Thu Jul 13 23:57:37 2017 Add support for VR tests with DON flow enabled Adds the ability to run VR instrumentation tests with the DON flow enabled. This is done by marking the test in question with the RESTRICTION_TYPE_DON_ENABLED restriction and passing the --don-enabled flag to the test runner. Most of the time, we want the DON flow to be skipped so that we can actually enter VR during automated testing. However, in some cases, we want to make sure that we aren't doing things while the DON flow is active, which requires it to be enabled. Also adds one test that uses this and enables it on our FYI bot. Bug: 737619 Change-Id: Ia20192065ace1f746a1bcdfcc503266b4330ee44 Reviewed-on: https://chromium-review.googlesource.com/567768 Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#486549} [modify] https://crrev.com/13f9a4aaceff4a745aff017d2de734e091086afc/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java [add] https://crrev.com/13f9a4aaceff4a745aff017d2de734e091086afc/chrome/android/shared_preference_files/test/vr_ddview_don_setupcomplete.json [modify] https://crrev.com/13f9a4aaceff4a745aff017d2de734e091086afc/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java [modify] https://crrev.com/13f9a4aaceff4a745aff017d2de734e091086afc/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeRestriction.java [add] https://crrev.com/13f9a4aaceff4a745aff017d2de734e091086afc/chrome/test/data/android/webvr_instrumentation/html/test_presentation_promise_unresolved_during_don.html [modify] https://crrev.com/13f9a4aaceff4a745aff017d2de734e091086afc/testing/buildbot/chromium.fyi.json
,
Jul 27 2017
,
Jul 4
,
Jul 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ddorwin@chromium.org
, Jul 7 2017