New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737611 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocked on:
issue 735117



Sign in to add a comment

Add colored google logo when search is active

Project Member Reported by newcomer@chromium.org, Jun 28 2017

Issue description

When the searchbox is active, show a colored google logo instead of the black one when the search provider is google.
 
Owner: maajid@chromium.org
Status: Assigned (was: Available)
Blockedon: 735117
will wait for https://codereview.chromium.org/2952763002/ to land. Once this change lands it's easier to check that the search is active (and doing it before would require a rewrite afterward anyway)
Status: Available (was: Assigned)

Comment 4 by maajid@chromium.org, Jul 17 2017

Status: Started (was: Available)
Had to update the asset colours manually because the skiafy tool does not handle colours, apparently.

This involved adding two lines:

NEW_PATH,
PATH_COLOR_ARGB, (followed by the appropriate colours)

after each CLOSE statement in the icon file. One PATH_COLOR_ARGB statement was needed at the beginning as well for the first path. note that the alpha value (the first hexadecimal value) is 0xFF for all of them.

Working on finishing the tests and getting the change reviewed now.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 18 2017

Comment 6 by maajid@chromium.org, Jul 19 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
9765.16.0, 61.0.3163.30

Sign in to add a comment