Add colored google logo when search is active |
||||||
Issue descriptionWhen the searchbox is active, show a colored google logo instead of the black one when the search provider is google.
,
Jul 6 2017
will wait for https://codereview.chromium.org/2952763002/ to land. Once this change lands it's easier to check that the search is active (and doing it before would require a rewrite afterward anyway)
,
Jul 6 2017
,
Jul 17 2017
Had to update the asset colours manually because the skiafy tool does not handle colours, apparently. This involved adding two lines: NEW_PATH, PATH_COLOR_ARGB, (followed by the appropriate colours) after each CLOSE statement in the icon file. One PATH_COLOR_ARGB statement was needed at the beginning as well for the first path. note that the alpha value (the first hexadecimal value) is 0xFF for all of them. Working on finishing the tests and getting the change reviewed now.
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/042dd5f76c827608ea7144fd08feb70e793b7476 commit 042dd5f76c827608ea7144fd08feb70e793b7476 Author: Maajid <maajid@chromium.org> Date: Tue Jul 18 20:11:47 2017 Add logic to use the colored Google search icon when the search is active. TEST: Unit tested, device tested with --enable-features=EnableFullcreenAppList Bug: 737611 Change-Id: I05727c4266b69ab33f22a09ecc582ac920d8ec8a Reviewed-on: https://chromium-review.googlesource.com/572548 Commit-Queue: Maajid <maajid@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#487576} [modify] https://crrev.com/042dd5f76c827608ea7144fd08feb70e793b7476/ui/app_list/vector_icons/BUILD.gn [add] https://crrev.com/042dd5f76c827608ea7144fd08feb70e793b7476/ui/app_list/vector_icons/ic_google_color.1x.icon [add] https://crrev.com/042dd5f76c827608ea7144fd08feb70e793b7476/ui/app_list/vector_icons/ic_google_color.icon [modify] https://crrev.com/042dd5f76c827608ea7144fd08feb70e793b7476/ui/app_list/views/search_box_view.cc [modify] https://crrev.com/042dd5f76c827608ea7144fd08feb70e793b7476/ui/app_list/views/search_box_view.h [modify] https://crrev.com/042dd5f76c827608ea7144fd08feb70e793b7476/ui/app_list/views/search_box_view_unittest.cc [modify] https://crrev.com/042dd5f76c827608ea7144fd08feb70e793b7476/ui/app_list/views/search_result_page_view.cc
,
Jul 19 2017
,
Aug 5 2017
9765.16.0, 61.0.3163.30 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by newcomer@chromium.org
, Jun 28 2017Status: Assigned (was: Available)