Update Chrome icon (Chrome menu anchor) has different color than the same icon inside the menu |
||||
Issue descriptionChrome Version: 61.0.3135.4 OS: Linux What steps will reproduce the problem? (1) Wait for upgrade (2) Open Chrome menu (3) Compare the icons What is the expected result? Icons are same What happens instead? Chrome menu anchor icon in the toolbar appears washed compared to sharp green icon in the menu item. Not sure if this is designed intentionally.
,
Jun 28 2017
Having a difference doesn't surprise me, since the toolbar is light and the menu background is dark. I'd expect us to pick different colors to maximize contrast. (The real bug here, maybe, is having a light toolbar and a dark menu; one of those seems like it should change.) What does surprise me is that the icons seem to have been selected backwards -- if we have a dark menu, that should have the lighter icon on it. Instead it's the darker icon.
,
Jul 10 2017
With the gtk theme we apparently try to pick a color smartly, but it seems like that's failing because the background should be considered light rather than dark in this case. [1] The menu does not try to theme the icon color at all and it would require some work to do so since the icon is controlled by the menu model which has no notion of the theme (native or otherwise). [2] [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/libgtkui/native_theme_gtk3.cc?rcl=1bd962c230c78176250bfa9f7b63e068dc18a6ac&l=373 [2] https://cs.chromium.org/chromium/src/chrome/browser/upgrade_detector.cc?rcl=1bd962c230c78176250bfa9f7b63e068dc18a6ac&l=39
,
Sep 19
|
||||
►
Sign in to add a comment |
||||
Comment 1 by varkha@chromium.org
, Jun 28 201712.8 KB
12.8 KB View Download