New issue
Advanced search Search tips

Issue 737603 link

Starred by 1 user
Status: Duplicate
Owner:
tandrii@chromium.org
Closed: Jul 2017
Cc:
aga...@chromium.org
jmad...@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Gerrit CQ: dry run should only require dry run perm for all changes in chain

Project Member Reported by jmad...@chromium.org, Jun 28 2017 
Not sure why running a try job requires deps to be approved. Not sure if this message is new or something particular to this CL:

https://chromium-review.googlesource.com/c/551535/

Dry run: CQ dry run requires all CL dependencies to be approved. Please, get approval on these CLs and re-trigger CQ dry run:

Can we allow dry runs on any CL if the reviewer/author has the appropriate permissions?

Comment 1 by aga...@chromium.org, Jun 28 2017

Cc: -tandrii@chromium.org aga...@chromium.org
Owner: tandrii@chromium.org
Status: Assigned (was: Available)
Summary: Gerrit CQ: dry run should only require dry run perm for all changes in chain (was: Gerrit CQ: dry run requires dependencies to be approved?)
This was changed recently and in parallel with the gerrit migration, although not strictly related to the gerrit migration. You can read the design and justification at https://docs.google.com/document/d/11V9PLRnFU76z-ULYGz5oBdc793Ght_QgiwqhK-M9SPI/edit#heading=h.2433qdborluw (sorry, internal doc).

Andrii, I know we've talked about relaxing that requirement to simply whether each change in the chain could be dry-run by the requester, instead of requiring that they all be approved. But I can't find a bug to that effect. Do you know where it is?

Comment 2 by aga...@chromium.org, Jun 28 2017

Labels: Milestone-Afterglow

Comment 3 by tandrii@chromium.org, Jul 3 2017

Mergedinto: 714246
Status: Duplicate (was: Assigned)
Issue 714246 is that one. Note that I agreed there for a more restrictive check for chain: checking that for each CL in a chain that CL is either approved or CL is created by a committer/dry-runner.
►

Sign in to add a comment