PasswordManagerBrowserTestBase.AutofillSuggestionsForProblematicPasswordForm flaked |
||||||
Issue descriptionPasswordManagerBrowserTestBase.AutofillSuggestionsForProblematicPasswordForm flaked: https://luci-milo.appspot.com/buildbot/chromium.mac/Mac10.11%20Tests/14501 [ RUN ] PasswordManagerBrowserTestBase.AutofillSuggestionsForProblematicPasswordForm [34774:14879:0628/013229.686204:WARNING:notification_platform_bridge_mac.mm(514)] AlertNotificationService: XPC connection invalidated. 2017-06-28 01:32:29.735 browser_tests[34774:379666] NSWindow warning: adding an unknown subview: <FullSizeContentView: 0x7f8504e557f0>. Break on NSLog to debug. 2017-06-28 01:32:29.735 browser_tests[34774:379666] Call stack: ( "+callStackSymbols disabled for performance reasons" ) [34774:45835:0628/013230.782219:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico ../../chrome/browser/password_manager/password_manager_test_base.cc:483: Failure Expected: expected_value Which is: "mypassword" To be equal to: return_value Which is: "" element_id = form_with_hidden_password_password [34774:775:0628/013230.809970:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1 [ FAILED ] PasswordManagerBrowserTestBase.AutofillSuggestionsForProblematicPasswordForm, where TypeParam = and GetParam() = (1407 ms)
,
Jul 11 2017
,
Jul 11 2017
+vasilii I haven't reviewed vabr's migration to TaskRunner but wonder: Is it possible that we need to call content::RunAllBlockingPoolTasksUntilIdle(); instead of run_loop.RunUntilIdle(); now?
,
Jul 11 2017
The test password store runs on the UI thread so that would continue to work. Anyway, I think we should remove all the RunLoop.RunUntilIdle() in our tests because they are a synonym to "I'm not sure what I'm doing". This test fails because we should wait for the password autofilled event instead of just checking it.
,
Jul 12 2017
,
Jul 13 2017
Vasilii volunteered to look into this.
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d438d5067572193483574fee790bd0d57f4f1904 commit d438d5067572193483574fee790bd0d57f4f1904 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Thu Jul 13 14:47:09 2017 Fix AutofillSuggestionsHiddenPasswordForm and AutofillSuggestionsForProblematicPasswordForm tests. Both tests are flaky for the same reason. They should wait til the password is autofilled because we don't know when the autofill code in renderer really processes the user gesture. Bug: 737551 Change-Id: Icee18f6d7a66d705988592d17b838487562a3940 Reviewed-on: https://chromium-review.googlesource.com/570162 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#486373} [modify] https://crrev.com/d438d5067572193483574fee790bd0d57f4f1904/chrome/browser/password_manager/password_manager_browsertest.cc
,
Jul 14 2017
Last flake occurred at commit position 486363. \o/ |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kavvaru@chromium.org
, Jul 6 2017