New issue
Advanced search Search tips

Issue 737547 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 737379
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1%-817.9% regression in smoothness.top_25_smooth at 482320:482537

Project Member Reported by tdres...@chromium.org, Jun 28 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=737547

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7tyBjQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgromL6wkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7o66tAsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7pz9kAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgruL2jQgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrqvGnQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrpLvgAgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgzoHmzwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7trhrgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrvL8nwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7ujQlgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7qipqwgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7szG6gkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrubklgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7qj24goM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrp_NngoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7rac_QoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgro2RsQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7qOeswsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7tyBjQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgromL6woM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrrPJ9gkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7pWSpgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrueovwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgruG09AsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrtan7wkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrqziiwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgroPj_AgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7rLM7woM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgromf-goM


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus5X
android-nexus6
chromium-rel-mac11-air
chromium-rel-win8-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 28 2017

Mergedinto: 737379
Status: Duplicate (was: Untriaged)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Chong Zhang
  Commit : 379f637084f5ccfe96bba687afaad8a75f53c3d5
  Date   : Mon Jun 26 21:23:59 2017
  Subject: Re-enable VsyncAlignedInput to Field Trial

Bisect Details
  Configuration: mac_air_perf_bisect
  Benchmark    : smoothness.top_25_smooth
  Metric       : first_gesture_scroll_update_latency/https___www.google.com_search?q_cats_tbm_isch
  Change       : 458.90% | 2.84083333333 -> 15.8775

Revision             Result                  N
chromium@482319      2.84083 +- 1.04833      6      good
chromium@482400      3.3795 +- 0.507923      6      good
chromium@482403      3.428 +- 0.567116       6      good
chromium@482404      3.16917 +- 1.35088      6      good
chromium@482405      17.0727 +- 19.7694      6      bad       <--
chromium@482410      17.4603 +- 18.5873      6      bad
chromium@482420      13.6877 +- 10.2662      6      bad
chromium@482440      16.5365 +- 13.1562      6      bad
chromium@482480      15.8775 +- 13.3555      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=https...www.google.com.search.q.cats.tbm.isch smoothness.top_25_smooth

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8975543260222048720

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6315007819644928


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c75487d4702daeff63df2bd7f4a288052cd054c

commit 7c75487d4702daeff63df2bd7f4a288052cd054c
Author: Chong Zhang <chongz@chromium.org>
Date: Tue Jul 04 21:03:40 2017

Flush TouchPad generated GestureScrollEnd immediately

Similar to  crbug.com/704732 , TouchPad generated gesture events will also
get delayed to next frame. (assuming MouseWheel events are always
blocking)

We want flush the queue to avoid regression on
'first_gesture_scroll_update_latency'.

Bug:  737547 
Change-Id: I43289864a3e8c528ce57c38dac7de529de8cd0f0
Reviewed-on: https://chromium-review.googlesource.com/557463
Commit-Queue: Chong Zhang <chongz@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484157}
[modify] https://crrev.com/7c75487d4702daeff63df2bd7f4a288052cd054c/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/7c75487d4702daeff63df2bd7f4a288052cd054c/ui/events/blink/input_handler_proxy_unittest.cc

Sign in to add a comment