Issue metadata
Sign in to add a comment
|
Background color missing for the MostVisited tiles in NewTabPage |
||||||||||||||||||||||
Issue descriptionApp Version: 61.0.3143.0 canary iOS Version: 9.3.5, 10.3.2 Device: iPhone5, iPhone7 URL: NA Steps to reproduce: 1. Launch Google Chrome Canary 2. Sign in with any test account that contains some most visited websites 3. Wait for the sync to complete and NewTabPage to update Observed results: Observe that Icons in NewTabPage doesn't have grey background color. Expected results: Most visited icons should have grey background color. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): M59 NO Bug reproducible on the current beta channel build (App Version, iOS Version): M60 NO Link to video/image: https://drive.google.com/file/d/0B-xmXLQhjeKuSFN0ZjZNVTlSSU0/view
,
Jun 28 2017
,
Jun 29 2017
MostVisted icons are now displayed correctly with the background color. Verified on M61.0.3144.0 canary Device: iPhone6, iPhone7 iOS: 10.2, 10.3.3
,
Jun 30 2017
This is reproducing again in M61.0.3145.0 canary Can you please take a look?
,
Jul 3 2017
This may interact with a feature to grab missing icons from a Google favicon server which is live in 50% of Canary on iOS: https://bugs.chromium.org/p/chromium/issues/detail?id=695810 As a result of this feature, you may see either colored tiles or even real favicons.
,
Jul 4 2017
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7b32792c24d871986beb9122802b2de86abf0f8 commit d7b32792c24d871986beb9122802b2de86abf0f8 Author: Elodie Banel <lod@google.com> Date: Thu Jul 06 14:56:25 2017 Fix rebase issue in gl mediator fallback callback Bug: 737541 Change-Id: Iecc391234eb1e9f04b7149259870288c59b69742 Reviewed-on: https://chromium-review.googlesource.com/561518 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Elodie Banel <lod@chromium.org> Cr-Commit-Position: refs/heads/master@{#484591} [modify] https://crrev.com/d7b32792c24d871986beb9122802b2de86abf0f8/ios/chrome/browser/ui/ntp/google_landing_mediator.mm
,
Jul 6 2017
a bad rebase reintroduced the issue. Fixed again (hopefully for good this time!)
,
Jul 11 2017
Verified on: App Version: 61.0.3154.0 canary Device: iPhone 6S Plus iOS Version: 10.3.1 MostVisited icons are displayed correctly with background colors. Please see the screenshot attached. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 28 2017