Cromoting connection unittests use GenericDecoder incorrectly. |
||
Issue description/src/remoting/protocol/connection_unittest.cc tests use webrtc_dummy_video_encoder.cc. In that situation after a single RequestFrame() call of a genericEncoder many OnEncodedImage will be called. Which breaks things. Is it possible to make dummy_video_encoder more in line with fake_encoder from webrtc opensource repository which actually takes one frame and produces one frame back?
,
Jun 28 2017
WebrtcDummyVideoEncoderFactory::EncoderTypeHasInternalSource() returns true, which means the encoder generates frames internally. See https://codesearch.chromium.org/chromium/src/third_party/webrtc/media/engine/webrtcvideoencoderfactory.h?type=cs&l=37
,
Jun 29 2017
Oh, I missed that, thank you! |
||
►
Sign in to add a comment |
||
Comment 1 by ilnik@chromium.org
, Jun 28 2017