New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737502 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task



Sign in to add a comment

atrusd: verity that multiple devices can be connected

Project Member Reported by lndmrk@chromium.org, Jun 28 2017

Issue description

We need to verify that nothing bad happens when multiple Atrus devices are connected simultaneously.
 

Comment 1 by lndmrk@chromium.org, Jun 28 2017

Labels: -Pri-3 Pri-2

Comment 2 by lndmrk@chromium.org, Jun 28 2017

Status: Started (was: Assigned)
Cc: rpattumani@chromium.org dsunk...@chromium.org mzhuo@chromium.org harpreet@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/atrusctl/+/6b432ca5f692d457b91052acd83ec4be453423cf

commit 6b432ca5f692d457b91052acd83ec4be453423cf
Author: Emil Lundmark <lndmrk@chromium.org>
Date: Thu Jul 06 12:00:30 2017

Ignore additional connected devices

We only need to support the use case where a single Atrus device is
connected to a CfM. This change will ensure that additional devices that
are connected will be ignored and don't e.g. clobber the logs.

BUG= chromium:737502 
TEST=Connected two devices and verified that the second one was ignored

Change-Id: Ia311ee033bfac4bb853d456fc169156128d9da54
Reviewed-on: https://chromium-review.googlesource.com/552152
Commit-Ready: Emil Lundmark <lndmrk@chromium.org>
Tested-by: Emil Lundmark <lndmrk@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Karl Petersson <karl@limesaudio.com>

[modify] https://crrev.com/6b432ca5f692d457b91052acd83ec4be453423cf/src/atrusd.cc

Status: Verified (was: Started)
Status: Assigned (was: Verified)
lndmrk@ - the bug summary and the CL description seem to be contradicting. My understanding is that multiple Atrus devices should be allowed. Please confirm.

Thanks
Labels: Proj-Bluestreak

Comment 8 by lndmrk@chromium.org, Jul 25 2017

Status: Fixed (was: Assigned)
harpreet@ for now, only a single device is supported (via USB). The CL
fixes an issue when you connect multiple devices, it essentially ignores
the additional devices.
lndmrk@ - to be clear about what "ignored" means, if there are multiple atrus' connected to guado via USB, only 1 of them will be functional? Others will essentially act as if they are not even powered on?
They will all be functional and powered on, but atrusctl will only
talk with one of them (the first one) and ignore the rest.

Comment 11 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment