atrusd: cleanup logic for diagnostics polling |
||||
Issue descriptionIn HIDConnection::WaitUntilReadable() there's a select(2) call. Currently, there's no handling for a timeout that occurs prematurely.
,
Jun 28 2017
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/atrusctl/+/88c21796519de5941d0e541f9b89bfae1c853617 commit 88c21796519de5941d0e541f9b89bfae1c853617 Author: Emil Lundmark <lndmrk@chromium.org> Date: Thu Jul 06 10:26:31 2017 Correctly indicate a timeout when polling diagnostics Previously, a generic error was interpreted as a timeout. BUG= chromium:737501 TEST=emerge-guado atrusctl Change-Id: Ib96535b44d0de13a11b5fbdcab37eacef9ff8f79 Reviewed-on: https://chromium-review.googlesource.com/552543 Commit-Ready: Emil Lundmark <lndmrk@chromium.org> Tested-by: Emil Lundmark <lndmrk@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> Reviewed-by: Karl Petersson <karl@limesaudio.com> [modify] https://crrev.com/88c21796519de5941d0e541f9b89bfae1c853617/src/hid_connection.cc [modify] https://crrev.com/88c21796519de5941d0e541f9b89bfae1c853617/src/hidraw_device.cc [modify] https://crrev.com/88c21796519de5941d0e541f9b89bfae1c853617/src/hid_connection.h
,
Jul 6 2017
,
Jul 18 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by lndmrk@chromium.org
, Jun 28 2017