New issue
Advanced search Search tips

Issue 737455 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 740816
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 736894



Sign in to add a comment

Files app: Move share functions out from "Open..." menu.

Project Member Reported by fukino@chromium.org, Jun 28 2017

Issue description

Chrome Version: ToT
OS: Chrome

In Files app, there is "Open..." menu in the tool bar.
Inside the menu, there can be many actions for the selected files.

It will be convenient to have "Share" button on the toolbar, and have share-related actions (e.g. Send with Gmail etc...) inside it.

Let me do some initial investigations...
 

Comment 1 by kinaba@chromium.org, Jun 28 2017

Each task item in the menu is represented as a structure (title, verb, icon, ...) at the level of fileManagerPrivate API.

https://codereview.chromium.org/1872223002/diff/300001/chrome/common/extensions/api/file_manager_private.idl

and combined into a menu item string at the UI side

https://codereview.chromium.org/1872223002/diff/300001/ui/file_manager/file_manager/foreground/js/file_tasks.js

I believe splitting them to two menues shouldn't be so hard.

Comment 2 by fukino@chromium.org, Jun 28 2017

weifangsun@,
We already have a share button for Drive files.
Should we merge it to the share menu?

Comment 3 by fukino@chromium.org, Jun 28 2017

Thank you kinaba@!
We seems to have enough information to separate share actions.

weifangsun@, is it OK if share actions can not be default actions? (Default action is an action executed on double-click on a file).
I guess most share actions are generic tasks, so they can not be default actions anyway. But I haven't confirmed it yet.

Comment 4 by kinaba@chromium.org, Jun 28 2017

All share actions from ARC are already generic and cannot be default anyway:
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/file_manager/arc_file_tasks.cc?type=cs&l=150


I don't know any other users of this verb outside ARC... I think it is negligible.
Blocking: 736894
fukino@, thanks for the initial investigation!

FYI, we've put together a one-pager and mocks at go/fileapp-osi | go filesapp-osi-mocks.

- For the share button, please see mocks - We'd like to update this button and move the current Drive share button as a specific Drive action.
- To confirm, share actions do not need to be available to set as a default action. (only Open With)

Comment 7 by fukino@chromium.org, Jun 28 2017

Thank you for the docs!
The correct links seems to be go/filesapp-osi and go/filesapp-osi-mocks :)

Comment 8 by fukino@chromium.org, Jun 29 2017

I added some comments on go/filesapp-osi-mocks .

Comment 9 by fukino@chromium.org, Jul 11 2017

Mergedinto: 740816
Status: Duplicate (was: Available)
Let me merge this issue to a tracking bug ( issue 740816 ) for go/filesapp-osi.
(since the request is not only about the menu UI change).

Sign in to add a comment