DCHECK fails when old_ink_drop_state is ACTION_PENDING |
|||
Issue descriptionSteps to reproduce: 1. Have Chrome OS be under load, or running in linux so that it's really slow. 2. Click on an app icon in the taskbar multiple times really fast. What should happen: App should open normally. What happens instead: I hit a dcheck: [9252:9252:0628/170747.470335:FATAL:square_ink_drop_ripple.cc(241)] Check failed: InkDropState::HIDDEN == old_ink_drop_state (0 vs. 1) old_ink_drop_state=ACTION_PENDING #0 0x7f210ef2389c base::debug::StackTrace::StackTrace() #1 0x7f210ef47d81 logging::LogMessage::~LogMessage() #2 0x7f210a540da5 views::SquareInkDropRipple::AnimateStateChange() #3 0x7f210a53fa5f views::InkDropRipple::AnimateToState() #4 0x7f210a53c7cf views::InkDropHostView::AnimateInkDrop() #5 0x7f210a54eeea views::CustomButton::OnMousePressed() #6 0x7f2109ce35d2 ash::ShelfButton::OnMousePressed() #7 0x7f210a5b8445 views::View::ProcessMousePressed() #8 0x7f210a5b827a views::View::OnMouseEvent() #9 0x7f210a53ca6f views::InkDropHostView::OnMouseEvent() #10 0x7f210b391362 ui::ScopedTargetHandler::OnEvent() #11 0x7f210b38f11b ui::EventDispatcher::ProcessEvent() #12 0x7f210b38eec7 ui::EventDispatcherDelegate::DispatchEvent() #13 0x7f210a5be298 views::internal::RootView::OnMousePressed() #14 0x7f210a5c3f40 views::Widget::OnMouseEvent() #15 0x7f210a5dff8f views::NativeWidgetAura::OnMouseEvent()
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b380725a81987b7ff8725ad40a02306ebdd358c9 commit b380725a81987b7ff8725ad40a02306ebdd358c9 Author: Ben Ruthig <bruthig@chromium.org> Date: Thu Aug 10 20:43:28 2017 Downgraded ink drop DCHECKs to DLOGs. The DCHECKs were failing due to race conditions during a heavily loaded system which is outside the scope of what they are supposed to be detecting, namely incorrect input event streams. Bug: 712715 , 737449 Change-Id: I5d540233f520cea304810b7bc64b7e3cd8dc71e7 Reviewed-on: https://chromium-review.googlesource.com/610364 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Ben Ruthig <bruthig@chromium.org> Cr-Commit-Position: refs/heads/master@{#493530} [modify] https://crrev.com/b380725a81987b7ff8725ad40a02306ebdd358c9/ui/views/animation/flood_fill_ink_drop_ripple.cc [modify] https://crrev.com/b380725a81987b7ff8725ad40a02306ebdd358c9/ui/views/animation/ink_drop_ripple.cc [modify] https://crrev.com/b380725a81987b7ff8725ad40a02306ebdd358c9/ui/views/animation/square_ink_drop_ripple.cc
,
Aug 10 2017
,
Jan 22 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bruthig@chromium.org
, Aug 10 2017