New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737448 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in blink::RecordingImageBufferSurface::DidDraw

Project Member Reported by ClusterFuzz, Jun 28 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5327466171465728

Fuzzer: inferno_twister_c
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::RecordingImageBufferSurface::DidDraw
  blink::HTMLCanvasElement::DidDraw
  blink::CanvasRenderingContext::DidDraw
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=482716:482739

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5327466171465728


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: msrchandra@chromium.org
Components: Blink>HTML
Labels: M-61 Test-Predator-Wrong-CLs
Owner: junov@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL did not provide any possible suspects.
Using Code Search for the file, "RecordingImageBufferSurface.cpp" assigning to the concern owner.
Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/5827cd0085ff673f5d89192761a4112e07dbb20c

@junov -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Project Member

Comment 2 by ClusterFuzz, Jul 11 2017

ClusterFuzz has detected this issue as fixed in range 485366:485396.

Detailed report: https://clusterfuzz.com/testcase?key=5327466171465728

Fuzzer: inferno_twister_c
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::RecordingImageBufferSurface::DidDraw
  blink::HTMLCanvasElement::DidDraw
  blink::CanvasRenderingContext::DidDraw
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=482716:482739
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=485366:485396

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5327466171465728


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 3 by ClusterFuzz, Jul 11 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5327466171465728 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Comment 4 by junov@chromium.org, Jul 11 2017

Status: Assigned (was: Verified)
Re-opening.  Bug is not really fix.  Code is still written in a way that is susceptible to overflow.

Comment 5 by junov@chromium.org, Jul 11 2017

Labels: ClusterFuzz-Wrong
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/933bab4b0fc11be16e657d2ac1f53e92615a58aa

commit 933bab4b0fc11be16e657d2ac1f53e92615a58aa
Author: Justin Novosad <junov@chromium.org>
Date: Fri Jul 14 01:20:16 2017

Make RecordingImageBufferSurface robust to int overflows

BUG= 737448 

Change-Id: I493919ce2ed8c4263b6b54684243b54bd38a2120
Reviewed-on: https://chromium-review.googlesource.com/567107
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486596}
[modify] https://crrev.com/933bab4b0fc11be16e657d2ac1f53e92615a58aa/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

Labels: -ClusterFuzz-Wrong
Status: Fixed (was: Assigned)
Seems fixed now - Chromium: 485366:485396

Sign in to add a comment