New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737440 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Do not share requests with different request modes

Project Member Reported by yhirano@chromium.org, Jun 28 2017

Issue description

It is currently allowed for requests handled by DocumentThreadableLoader. I think it's not good.

This disables the matching between a link preload without crossorigin attribute set and XHR.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5119b1c4ce8da8566eb36062ee724ae2f572a7e1

commit 5119b1c4ce8da8566eb36062ee724ae2f572a7e1
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Mon Jul 24 04:38:38 2017

Stop sharing resources having different fetch request mode

This CL stops reusing "no-cors" resources with "cors" (or
"same-origin") requests and vice versa. See the following thread
for details.

https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/kfE0RHQrULA/RWD3kmfRAQAJ


Bug:  737440 
Change-Id: I11ca27c0138a6a1d72f64d8229023f90ea1c2245
Reviewed-on: https://chromium-review.googlesource.com/561266
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488910}
[modify] https://crrev.com/5119b1c4ce8da8566eb36062ee724ae2f572a7e1/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/5119b1c4ce8da8566eb36062ee724ae2f572a7e1/third_party/WebKit/LayoutTests/http/tests/preload/memcache_reuse_of_non_cacheable_preload.html
[add] https://crrev.com/5119b1c4ce8da8566eb36062ee724ae2f572a7e1/third_party/WebKit/LayoutTests/http/tests/preload/preload-fetch-mode-mismatch.html
[modify] https://crrev.com/5119b1c4ce8da8566eb36062ee724ae2f572a7e1/third_party/WebKit/Source/platform/loader/fetch/Resource.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment