New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737433 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug


Participants' hotlists:
Fixing-touch


Sign in to add a comment

keyboard_unittests doesn't run on chromeos buildbots.

Project Member Reported by yhanada@chromium.org, Jun 28 2017

Issue description

Let's make the test run on chromeos buildbots.
 
Owner: yhanada@chromium.org
Status: Started (was: Available)
I uploaded crrev.com/c/551436
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa66128ad5e2960db19f64b5949962409cc55f95

commit fa66128ad5e2960db19f64b5949962409cc55f95
Author: yhanada <yhanada@chromium.org>
Date: Thu Jul 13 03:09:11 2017

Add keyboard_unittests to the mojo fyi builder.

- Added missing data_deps to ui_test.pak.

Bug:  737433 
Change-Id: I4cb4ad39b8baebeb40ef2bc081741182e2ff2b5b
Reviewed-on: https://chromium-review.googlesource.com/567785
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486247}
[modify] https://crrev.com/fa66128ad5e2960db19f64b5949962409cc55f95/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/fa66128ad5e2960db19f64b5949962409cc55f95/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/fa66128ad5e2960db19f64b5949962409cc55f95/ui/keyboard/BUILD.gn

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d87cff38b9bb0a936e5a15f9b1f64a4e6d88980a

commit d87cff38b9bb0a936e5a15f9b1f64a4e6d88980a
Author: yhanada <yhanada@chromium.org>
Date: Thu Jul 13 08:00:11 2017

Fix data_deps of //ui/keyboard/keyboard_unittests.

Bug:  737433 
Change-Id: Ifa154abf20a8588754e5de2a33d4c851326e75b2
Reviewed-on: https://chromium-review.googlesource.com/569524
Reviewed-by: Keigo Oka <oka@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486312}
[modify] https://crrev.com/d87cff38b9bb0a936e5a15f9b1f64a4e6d88980a/ui/keyboard/BUILD.gn

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6b9521935ac7ebc2e15da197ddd8bd26432bb87

commit d6b9521935ac7ebc2e15da197ddd8bd26432bb87
Author: yhanada <yhanada@chromium.org>
Date: Fri Jul 14 01:58:43 2017

Add keyboard_unittests to the chromiumos buildbots.

- Added an entry to chromium.chromiumos.json.
- Added missing data_deps to ui_test.pak.

Bug:  737433 
Test: keyboard_unittests runs on the chromiumos bots.
Change-Id: I17bdf38c9012372221580c811cf28d4b8e63258e
Reviewed-on: https://chromium-review.googlesource.com/551436
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486627}
[modify] https://crrev.com/d6b9521935ac7ebc2e15da197ddd8bd26432bb87/testing/buildbot/chromium.chromiumos.json

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment