New issue
Advanced search Search tips

Issue 737430 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

GN create_bundle doesn't support output_name argument

Project Member Reported by liaoyuke@chromium.org, Jun 28 2017

Issue description

The name of the generated bundle by create_bundle is the same as the target name, seems that there is no way to specify a separate output_name argument.
 
Status: WontFix (was: Untriaged)
The create_bundle target does support giving the full path of the generated bundle via the bundle_root_dir variable as documented in "gn help create_bundle".

So, the following works:

  create_bundle("foo") {
    bundle_root_dir = "$root_build_dir/Bar.app"
    ...
  }

and will create a product named Bar.app in $root_build_dir. The target does not support a simple "product_name" because it allows a more powerful way to specify the name of the output.

Closing as WontFix since this is WAI.
Thanks for explaining Sylvain! I thought the bundle_root_dir is only used to pass to bundle_data.

If this works, then I think "all" doesn't need to depend on both "xcuitest" and "xcuitest_runner" anymore.

in the new design, we can have "xcuitest" as a group, which depends on "xcuitest_runner" and "xcuitest_module", and then "xcuitest_runner" creates "xcuitest-Runner.app" and "xcuitest_module" creates "xcuitest.xctest". I'll try implementing this and see how it goes.

Sign in to add a comment