New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 737419 link

Starred by 3 users
Status: Fixed
Owner:
█ shanmug...@samsung.com
Last visit > 30 days ago
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 651762



Sign in to add a comment

Implement <data> element

Project Member Reported by tkent@chromium.org, Jun 28 2017 
Chrome Version: 61 canary
OS: All but iOS

What steps will reproduce the problem?
(1) Open the following URL
data:text/html;charset=utf-8,<data value="PASS"></data><script>alert(document.querySelector('data').value)</script>

What is the expected result?
It should open a dialog saying "PASS".

What happens instead?
It opens a dialog saying "undefined".

Please use labels and text to provide additional information.

https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-data-element

Comment 2 by shanmug...@samsung.com, Jun 28 2017

Owner: shanmug...@samsung.com
Status: Assigned (was: Available)

Comment 3 by tkent@chromium.org, Jun 28 2017 

shanmuga.m@, will you send intent-to-implement-and-ship to blink-dev?

Comment 4 by shanmug...@samsung.com, Jun 28 2017 

tkent@, sure. I will send it today.

Comment 6 by tkent@chromium.org, Jun 28 2017

Labels: -Needs-BlinkIntent
The intent was approved.

Comment 7 by shanmug...@samsung.com, Jun 29 2017

Status: Started (was: Assigned)

Comment 8 Deleted

Comment 9 Deleted

Comment 10 Deleted

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14ab691e9250faa25b2e5a713061cbfdb607348a

commit 14ab691e9250faa25b2e5a713061cbfdb607348a
Author: Shanmuga Pandi M <shanmuga.m@samsung.com>
Date: Mon Jul 24 11:01:18 2017

Implement <data> element

spec:
https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-data-element

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/IjFvnq8yzy8

Bug:  737419 
Change-Id: I512702778ec58338587e465f5614927c2323a531
Reviewed-on: https://chromium-review.googlesource.com/552597
Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488940}
[modify] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/third_party/WebKit/LayoutTests/custom-elements/spec/define-builtin-element.html
[modify] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Node-cloneNode-expected.txt
[modify] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/third_party/WebKit/LayoutTests/external/wpt/html/dom/interfaces-expected.txt
[modify] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/third_party/WebKit/LayoutTests/external/wpt/html/dom/reflection-text-expected.txt
[modify] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/third_party/WebKit/LayoutTests/external/wpt/html/semantics/interfaces-expected.txt
[delete] https://crrev.com/90b49764d2735111c3f6463cd3b4919cd224f6bc/third_party/WebKit/LayoutTests/external/wpt/html/semantics/text-level-semantics/the-data-element/data.value-001-expected.txt
[add] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/third_party/WebKit/LayoutTests/html/text_level_semantics/data-rendering-expected.html
[add] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/third_party/WebKit/LayoutTests/html/text_level_semantics/data-rendering.html
[modify] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/third_party/WebKit/Source/core/html/BUILD.gn
[add] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/third_party/WebKit/Source/core/html/HTMLDataElement.cpp
[add] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/third_party/WebKit/Source/core/html/HTMLDataElement.h
[add] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/third_party/WebKit/Source/core/html/HTMLDataElement.idl
[modify] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/third_party/WebKit/Source/core/html/HTMLTagNames.json5
[modify] https://crrev.com/14ab691e9250faa25b2e5a713061cbfdb607348a/third_party/WebKit/Source/core/html/HTMLUnknownElement.cpp

Comment 12 by shanmug...@samsung.com, Jul 24 2017

Status: Fixed (was: Started)

Comment 13 by tkent@chromium.org, Jul 24 2017

Labels: M-62

Comment 14 by tkent@chromium.org, Jul 26 2017

Blocking: 651762

Comment 15 by rbyers@chromium.org, Aug 8 2017 

I'm looking over a list of APIs shipped in the other major engines for >6 months but not chromium (up to latest current stable) and found this one.  Thank you for shipping it and making all the major engines agree!

Comment 16 by djebb...@gmail.com, Sep 27 2017 

bjjjjhjhj
►

Sign in to add a comment