Weird app shelf behavoir
Reported by
afinenda...@gmail.com,
Jun 28 2017
|
|||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; CrOS x86_64 9592.29.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.41 Safari/537.36 Platform: 9592.29.0 (Official Build) beta-channel orco Steps to reproduce the problem: 1. Right click on an app on the shelf 2. Click and drag on another app 3. What is the expected behavior? The second app would be dragged. What went wrong? The first right clicked app was dragged instead and acted weirdly. Did this work before? N/A Chrome version: 60.0.3112.41 Channel: beta OS Version: 9592.29.0 Flash Version: Shockwave Flash 26.0 r0 This is a very very small bug. Also if when you drag you go slowly, the first app with be push the the left and eventually drag normally This also happens with the music app although it doesn't "launch" when it's on the shelf but not with the the omnibox/search box. Lastly, am I only supposed to report bugs about the browser or ChromeOS in general. Thanks
,
Jul 5 2017
,
Jul 5 2017
CL: https://chromium-review.googlesource.com/c/559829/
,
Jul 5 2017
This is also in M60. Looks like Release Blocker.
,
Jul 5 2017
Beside the dragging there is also some problem with left invalid ink effect and context of next button press/touch. In debug builds this leads to DCHECK() crashes.
,
Jul 5 2017
This likely regressed in: https://codereview.chromium.org/2876203003 khmel@ has a wip fix: https://chromium-review.googlesource.com/c/559829
,
Jul 5 2017
Oops, that change actually hasn't landed, I'm not sure what caused this.
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b555e5e2e711754168e8603c4291d443bae51250 commit b555e5e2e711754168e8603c4291d443bae51250 Author: khmel <khmel@google.com> Date: Thu Jul 06 00:13:53 2017 Fix shelf dragging context in case Context Menu is shown. In case context menu is shown for the shelf button it prevents next mouse released events. Not handling this event leaves shelf view in incorrect state when dragging target is set for the button used to show the context menu. This CL manually released mouse caputure in this case. TEST=Manually on device + browser test. BUG= 737407 Change-Id: I32ac29b26300efba388cb09ecb5717ecd0de2001 Reviewed-on: https://chromium-review.googlesource.com/559829 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#484387} [modify] https://crrev.com/b555e5e2e711754168e8603c4291d443bae51250/ash/shelf/shelf_button.cc [modify] https://crrev.com/b555e5e2e711754168e8603c4291d443bae51250/ash/shelf/shelf_view.h [modify] https://crrev.com/b555e5e2e711754168e8603c4291d443bae51250/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
,
Jul 10 2017
Can we CP this into M60?
,
Jul 10 2017
Yes, requesting MERGE
,
Jul 10 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 12 2017
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a146c77d0a3ecdb0dce7bd2d3048c4d61df273d2 commit a146c77d0a3ecdb0dce7bd2d3048c4d61df273d2 Author: khmel <khmel@chromium.org> Date: Wed Jul 12 18:58:00 2017 [Merge M60] Fix shelf dragging context in case Context Menu is shown. In case context menu is shown for the shelf button it prevents next mouse released events. Not handling this event leaves shelf view in incorrect state when dragging target is set for the button used to show the context menu. This CL manually released mouse caputure in this case. TEST=Manually on device + browser test. BUG= 737407 TBR=msw@chromium.org NOTRY=true NOPRESUBMIT=true Change-Id: I32ac29b26300efba388cb09ecb5717ecd0de2001 Reviewed-on: https://chromium-review.googlesource.com/559829 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#484387} (cherry picked from commit b555e5e2e711754168e8603c4291d443bae51250) Review-Url: https://codereview.chromium.org/2975063003 Cr-Commit-Position: refs/branch-heads/3112@{#597} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/a146c77d0a3ecdb0dce7bd2d3048c4d61df273d2/ash/shelf/shelf_button.cc [modify] https://crrev.com/a146c77d0a3ecdb0dce7bd2d3048c4d61df273d2/ash/shelf/shelf_view.h [modify] https://crrev.com/a146c77d0a3ecdb0dce7bd2d3048c4d61df273d2/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
,
Jul 12 2017
,
Jul 27 2017
9592.71.0, 60.0.3112.80 |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by mitsuji@chromium.org
, Jun 30 2017Status: Assigned (was: Unconfirmed)