New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737403 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Please use my @vewd.com account ins...
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 667238



Sign in to add a comment

Deprecate and remove WTF's OS() macro

Project Member Reported by tkent@chromium.org, Jun 28 2017

Issue description

Replace OS(FOO) usage with defined(OS_FOO).

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a8755d3cdb7942774fce550a3a9f2d9dc56fe1a

commit 5a8755d3cdb7942774fce550a3a9f2d9dc56fe1a
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Jun 29 23:37:07 2017

Check OS_*, COMPILER_*, ARCH_CPU_*, WCHAR_T_IS_* usage without build/build_config.h

If we use these macros without including build_config.h, a preprocessor silently
removes enclosed code blocks, and developers might waste a lot of time to
investigate unexpected behavior. So checking build_config.h inclusion is helpful.

In many cases, build_config.h is included indirectly, and macros work well
without including it explicitly. However, we should include it explicitly anyway
because of IWYU.


Bug:  737403 
Change-Id: I6e75167d36c176091b0100dd40a4091cc1e25d1b
Reviewed-on: https://chromium-review.googlesource.com/553658
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483547}
[modify] https://crrev.com/5a8755d3cdb7942774fce550a3a9f2d9dc56fe1a/PRESUBMIT.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/596d1b0ddfc757789a84426e5c5e10eb55fa3343

commit 596d1b0ddfc757789a84426e5c5e10eb55fa3343
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Jun 29 23:48:27 2017

Deprecate WTF's OS() macro.

This CL allows to include build/build_config.h in third_party/WebKit/Source,
removes a check for OS_*, and adds a deprecation message for OS().

Bug:  737403 
Change-Id: I4f71ea1cb6c235fd8311f49db3cfc0a3fb2ec11d
Reviewed-on: https://chromium-review.googlesource.com/551397
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483550}
[modify] https://crrev.com/596d1b0ddfc757789a84426e5c5e10eb55fa3343/third_party/WebKit/PRESUBMIT.py
[modify] https://crrev.com/596d1b0ddfc757789a84426e5c5e10eb55fa3343/third_party/WebKit/Source/DEPS
[modify] https://crrev.com/596d1b0ddfc757789a84426e5c5e10eb55fa3343/third_party/WebKit/Source/platform/wtf/DEPS
[modify] https://crrev.com/596d1b0ddfc757789a84426e5c5e10eb55fa3343/third_party/WebKit/Source/platform/wtf/build_config.h

Comment 3 by tkent@chromium.org, Jul 6 2017

Owner: most...@opera.com
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93880a670c0ecb47409786f841694a1bd1e5b3e9

commit 93880a670c0ecb47409786f841694a1bd1e5b3e9
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Fri Jul 07 08:11:45 2017

remove the OS() macro

Replace OS(FOO) macro calls with defined(OS_FOO) and remove the OS macro.

This is mostly a mechanical change:

for p in MACOSX LINUX WIN ANDROID POSIX FREEBSD OPENBSD
do
	for file in `git grep -w "OS($p)" | sed -e "s/:.*//" | uniq`
	do
		sed -i -e "s/OS($p)/defined(OS_$p)/g" $file
	done
done

Followed by some semi-automatic build/build_config.h inclusion
and clang format.

BUG= 737403 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I69e567334665c331b46e04be86a60aeca4a3e9c4
Reviewed-on: https://chromium-review.googlesource.com/561010
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484853}
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/PRESUBMIT.py
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/bindings/core/v8/V8GCForContextDispose.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/clipboard/Pasteboard.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/css/CSSFontSelector.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/dom/ViewportDescription.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/editing/EditingBehavior.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/editing/KeyboardTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/editing/commands/SmartReplaceICU.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/events/KeyboardEvent.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/events/UIEventWithKeyState.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/exported/WebAssociatedURLLoaderImplTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/exported/WebPluginContainerImpl.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/exported/WebPluginContainerTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/frame/BrowserControlsTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/frame/MHTMLTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/frame/NavigatorID.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/frame/Settings.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/html/forms/ExternalPopupMenu.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/html/forms/InternalPopupMenu.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/html/forms/SpinButtonElement.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/imagebitmap/ImageBitmapTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/input/GestureManager.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/input/KeyboardEventManager.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/input/MouseEventManager.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/input/MouseWheelEventManager.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/inspector/InspectorOverlayAgent.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/layout/LayoutTableCellTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/layout/LayoutTableRowTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/layout/LayoutThemeMobile.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/layout/ScrollbarsTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/loader/NavigationPolicy.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/page/EffectiveNavigationPolicyTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/core/style/ComputedStyleTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegate.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/KeyboardCodes.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/MemoryCoordinator.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/SecureTextInput.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/SecureTextInput.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/WebThread.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/audio/Biquad.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/audio/Biquad.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/audio/FFTFrame.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/audio/FFTFrameStub.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/audio/PushPullFIFO.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/audio/Reverb.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/audio/VectorMath.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/audio/mac/FFTFrameMac.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/clipboard/ClipboardUtilities.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/exported/FilePathConversion.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/fonts/AlternateFontFamily.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/fonts/FontCache.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/fonts/FontCache.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/fonts/FontCacheTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/fonts/FontFaceCreationParams.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/fonts/FontPlatformData.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/fonts/SimpleFontData.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/fonts/WebFontDecoder.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/fonts/linux/FontCacheLinux.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/fonts/linux/FontRenderStyle.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/fonts/skia/SkiaTextMetrics.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/geometry/FloatPoint.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/geometry/FloatRect.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/geometry/FloatSize.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/geometry/IntPoint.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/geometry/IntRect.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/geometry/IntSize.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/graphics/skia/SkiaUtils.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/heap/HeapPage.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/heap/StackFrameDepth.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/heap/ThreadState.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/loader/fetch/Resource.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/testing/BlinkPerfTestSuite.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/text/HyphenationTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/text/LineEnding.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/Assertions.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/Assertions.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/ByteOrder.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/DataLog.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/DateMath.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/MathExtras.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/README.md
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/StackUtil.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/StringExtras.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/StringExtrasTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/ThreadSpecific.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/ThreadSpecificWin.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/Threading.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/ThreadingPrimitives.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/ThreadingPthreads.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/ThreadingWin.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/build_config.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/text/AtomicString.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/text/AtomicStringCF.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/text/StringImpl.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/platform/wtf/text/StringImplCF.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/web/WebViewImpl.h
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/web/tests/LayoutGeometryMapTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/web/tests/VirtualTimeTest.cpp
[modify] https://crrev.com/93880a670c0ecb47409786f841694a1bd1e5b3e9/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Comment 5 by most...@opera.com, Jul 7 2017

Status: Fixed (was: Started)

Sign in to add a comment