Issue metadata
Sign in to add a comment
|
1.9%-2.5% regression in smoothness.top_25_smooth at 482266:482343 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 28 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8975579319059157728
,
Jun 28 2017
=== Auto-CCing suspected CL author treib@chromium.org === Hi treib@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Marc Treib Commit : 6fb10fe065b1cfe4c4aa691c31c03e7387a72d40 Date : Mon Jun 26 18:39:55 2017 Subject: Fieldtrial testing config for CaptureThumbnailOnLoadFinished Bisect Details Configuration: winx64nvidia_perf_bisect Benchmark : smoothness.top_25_smooth Metric : frame_times/http___news.yahoo.com Change : 1.10% | 16.3094508853 -> 16.489198137 Revision Result N chromium@482265 16.3095 +- 0.0370989 6 good chromium@482304 16.3271 +- 0.102492 6 good chromium@482324 16.2896 +- 0.189163 6 good chromium@482334 16.2934 +- 0.176814 9 good chromium@482335 16.283 +- 0.141123 6 good chromium@482336 16.422 +- 0.162446 6 bad <-- chromium@482337 16.4406 +- 0.211863 9 bad chromium@482339 16.4988 +- 0.247872 6 bad chromium@482343 16.4892 +- 0.151525 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...news.yahoo.com smoothness.top_25_smooth Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8975579319059157728 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5585624528060416 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jun 28 2017
,
Jun 28 2017
,
Jun 28 2017
Issue 737598 has been merged into this issue.
,
Jun 28 2017
Yup, this is almost certainly mine. I guess the correct procedure is to revert the fieldtrial config change while I investigate how to improve things.
,
Jun 28 2017
Issue 737596 has been merged into this issue.
,
Jun 28 2017
,
Jun 29 2017
Issue 737703 has been merged into this issue.
,
Jun 29 2017
Issue 738125 has been merged into this issue.
,
Jun 29 2017
Revert is in the CQ: https://chromium-review.googlesource.com/c/556159
,
Jun 29 2017
,
Jun 29 2017
Issue 738086 has been merged into this issue.
,
Jun 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a4f9830425ae18fde542707bb1fbcb617d07768 commit 7a4f9830425ae18fde542707bb1fbcb617d07768 Author: Marc Treib <treib@chromium.org> Date: Thu Jun 29 22:42:07 2017 Revert "Fieldtrial testing config for CaptureThumbnailOnLoadFinished" This reverts commit 6fb10fe065b1cfe4c4aa691c31c03e7387a72d40. Reason for revert: Perf regressions, see crbug.com/737396 Original change's description: > Fieldtrial testing config for CaptureThumbnailOnLoadFinished > > Bug: 718413 > Change-Id: I98eae051b6e19cedeb8b9f4cff2da6dcc7886d11 > Reviewed-on: https://chromium-review.googlesource.com/548719 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#482336} TBR=isherman@chromium.org,treib@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 718413 , 737396 Change-Id: I186e304e227e2fe979341dd22b0f775b67fcc070 Reviewed-on: https://chromium-review.googlesource.com/556159 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#483524} [modify] https://crrev.com/7a4f9830425ae18fde542707bb1fbcb617d07768/testing/variations/fieldtrial_testing_config.json
,
Jul 3 2017
,
Jul 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fce9531fe6af8d6b47a992888a21174f8e6ec1c5 commit fce9531fe6af8d6b47a992888a21174f8e6ec1c5 Author: Marc Treib <treib@chromium.org> Date: Wed Jul 05 08:09:55 2017 Thumbnails: Move score computation off the UI thread Metrics show that the computation (specifically, color_utils::CalculateBoringScore) can be fairly expensive, so move it off the UI thread, into a background task runner. Bug: 737396 , 718413 Change-Id: I82baca452bcd4bdda0fd225530e69aad189e95a5 Reviewed-on: https://chromium-review.googlesource.com/558924 Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#484213} [modify] https://crrev.com/fce9531fe6af8d6b47a992888a21174f8e6ec1c5/chrome/browser/thumbnails/thumbnail_tab_helper.cc
,
Jul 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da2086682fef5cc44b539dc4bdc63af380e2988b commit da2086682fef5cc44b539dc4bdc63af380e2988b Author: Marc Treib <treib@chromium.org> Date: Tue Jul 11 09:16:07 2017 Fieldtrial testing config for CaptureThumbnailOnLoadFinished This is mostly a reland of https://chromium-review.googlesource.com/548719 which was reverted because of perf impact. In the meantime, https://chromium-review.googlesource.com/558924 has landed which hopefully improves performance. It also adds the CaptureThumbnailDependingOnTransitionType feature, since the two will likely launch together (and that might also alleviate the perf impact). Bug: 718413 , 737396 Change-Id: I0ef909f0015d07a3f908d0ba3dc52f6a897a53b1 Reviewed-on: https://chromium-review.googlesource.com/563202 Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#485568} [modify] https://crrev.com/da2086682fef5cc44b539dc4bdc63af380e2988b/testing/variations/fieldtrial_testing_config.json
,
Jul 11 2017
New fieldtrial config is in - hopefully the perf regressions have been resolved. Let's see if the bots trigger again...
,
Jul 13 2017
Okay, seems that most, but not all perf regressions were fixed. Now tracking at bug 741856
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c81cac01282f636fe594df9ae56b513cbfa4031 commit 1c81cac01282f636fe594df9ae56b513cbfa4031 Author: Marc Treib <treib@chromium.org> Date: Thu Jul 13 14:49:27 2017 Revert "Fieldtrial testing config for CaptureThumbnailOnLoadFinished" This reverts commit da2086682fef5cc44b539dc4bdc63af380e2988b. Reason for revert: Still perf regressions, though fewer of them. See crbug.com/741856 Original change's description: > Fieldtrial testing config for CaptureThumbnailOnLoadFinished > > This is mostly a reland of https://chromium-review.googlesource.com/548719 > which was reverted because of perf impact. In the meantime, > https://chromium-review.googlesource.com/558924 has landed which hopefully > improves performance. > > It also adds the CaptureThumbnailDependingOnTransitionType feature, since > the two will likely launch together (and that might also alleviate the > perf impact). > > Bug: 718413 , 737396 > Change-Id: I0ef909f0015d07a3f908d0ba3dc52f6a897a53b1 > Reviewed-on: https://chromium-review.googlesource.com/563202 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485568} TBR=isherman@chromium.org,treib@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 718413 , 741856 Change-Id: Ic2479ad7c0e3e32c7621a2e80385d64da5029aea Reviewed-on: https://chromium-review.googlesource.com/570218 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#486374} [modify] https://crrev.com/1c81cac01282f636fe594df9ae56b513cbfa4031/testing/variations/fieldtrial_testing_config.json
,
Jul 18 2017
The NextAction date has arrived: 2017-07-18 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by sullivan@chromium.org
, Jun 28 2017