Issue metadata
Sign in to add a comment
|
2.3%-37.4% regression in system_health.common_desktop at 481836:481991 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 28 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8975580445123479936
,
Jun 28 2017
=== Auto-CCing suspected CL author ajith.v@samsung.com === Hi ajith.v@samsung.com, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : ajith.v Commit : 4eb6812cc312e4ea919518a4e3087944e31b3b72 Date : Fri Jun 23 13:38:16 2017 Subject: Relanding [Android] Adding Smart GO/NEXT feature in Chrome Bisect Details Configuration: mac_10_12_perf_bisect Benchmark : system_health.common_desktop Metric : cpu_time_percentage_avg/browse_social/browse_social_facebook_infinite_scroll Change : 34.27% | 0.472535769612 -> 0.634453614884 Revision Result N chromium@481847 0.472536 +- 0.00815711 6 good chromium@481859 0.475802 +- 0.00653534 6 good chromium@481865 0.474721 +- 0.00792525 6 good chromium@481867 0.477041 +- 0.0124672 6 good chromium@481868 0.63432 +- 0.00435245 6 bad <-- chromium@481870 0.634834 +- 0.00633198 6 bad chromium@481892 0.631641 +- 0.00641483 6 bad chromium@481937 0.634454 +- 0.00646176 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.social.facebook.infinite.scroll system_health.common_desktop Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8975580445123479936 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5524915836420096 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jun 28 2017
,
Jun 28 2017
This looks a significant perf regression, I'll revert this for ajith.v to investigate.
,
Jun 28 2017
,
Jun 28 2017
ajith.v, this time the regression should be easier to analyze than previous one (power.android_acceptance) - the scrolling performance would be affected by newly added code when some element is focused, I guess.
,
Jun 28 2017
kochi@ - If we restrict NextFocusableElementInForm() call only for IsTextControlElement() or for HTMLFormControlElement from InputMethodController::TextInputFlags(), will it have any improvement ?
,
Jun 28 2017
Also is it possible to reproduce the results locally ?
I had executed ./tools/perf/run_benchmark -v --browser=content-shell-default --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.social.facebook.infinite.scroll system_health.common_desktop
and got following results due to permission issue.
(INFO) 2017-06-28 20:51:35,813 archive_info.DownloadArchivesIfNeeded:110 All WPR archives are downloaded, took 1.56673312187 seconds.
(INFO) 2017-06-28 20:51:35,813 exception_formatter.PrintFormattedException:19 Try printing formatted exception: None None None
Traceback (most recent call last):
RunBenchmark at /home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:406
expectations=expectations, metadata=benchmark.GetMetadata())
Run at /home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:229
story_set.archive_data_file, story_set.wpr_archive_info, stories):
_UpdateAndCheckArchives at /home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:454
wpr_archive_info.DownloadArchivesIfNeeded()
DownloadArchivesIfNeeded at /home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/third_party/catapult/telemetry/telemetry/wpr/archive_info.py:107
download_if_needed(archive_path)
download_if_needed at /home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/third_party/catapult/telemetry/telemetry/wpr/archive_info.py:86
cloud_storage.GetIfChanged(path, self._bucket)
GetIfChanged at /home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/third_party/catapult/common/py_utils/py_utils/cloud_storage.py:422
_GetLocked(bucket, expected_hash, file_path)
_GetLocked at /home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/third_party/catapult/common/py_utils/py_utils/cloud_storage.py:348
_RunCommand(['cp', url, partial_download_path.name])
_RunCommand at /home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/third_party/catapult/common/py_utils/py_utils/cloud_storage.py:153
raise GetErrorObjectForCloudStorageStderr(stderr)
PermissionError: Attempted to access a file from Cloud Storage but you don't have permission. To configure your credentials:
1. Run "/home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/third_party/catapult/third_party/gsutil/gsutil config" and follow its instructions.
2. If you have a @google.com account, use that account.
3. For the project-id, just enter 0.
Locals:
args : ['/home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/third_party/catapult/third_party/gsutil/gsutil', 'cp', 'gs://chrome-partner-telemetry/d402a17e3c6de27aacc43997b935b4cff1452fcd', u'/home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/tools/perf/page_sets/data/tmpNgAuNV']
gsutil : <subprocess.Popen object at 0x7f5808754150>
gsutil_env : None
stderr : 'AccessDeniedException: 403 Caller does not have storage.objects.list access to bucket chrome-partner-telemetry.\n'
stdout : ''
[ PASSED ] 0 tests.
View result at file:///home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/tools/perf/results-chart.json
,
Jun 29 2017
Re #8 - could be, but you would get better idea by actually measuring it. Re #9 - if you have any issue following the message at the bottom (except 2): 1. Run "/home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/third_party/catapult/third_party/gsutil/gsutil config" and follow its instructions. 2. If you have a @google.com account, use that account. 3. For the project-id, just enter 0. Please let me know. And as a general advice, it is better to split a large CL into smaller pieces, and land one by one.
,
Jun 29 2017
kochi@ - I already configured gsutil with following success message; Boto config file "/home/ajithk/.boto" created. If you need to use a proxy to access the Internet please see the instructions in that file. So errors in #10 is not a problem with me. From error from #9 after seeing below comment, stderr : 'AccessDeniedException: 403 Caller does not have storage.objects.list access to bucket chrome-partner-telemetry.\n' I feel, I have to follow http://www.chromium.org/developers/telemetry/upload_to_cloud_storage and send an email to telemetry@chromium.org for telemetry access. Please share your thoughts on this. I agree with your suggestion of splitting this patch into multiple CLs. I will start it in my next patch.
,
Jun 29 2017
kochi@ - I got permission from telemetry@ After running the test with current patch, I got following output; (INFO) 2017-06-29 22:54:37,116 browser._LogBrowserInfo:130 GPU device 0: VENDOR = 0x8086 (Intel), DEVICE = 0x162 (INFO) 2017-06-29 22:54:37,116 browser._LogBrowserInfo:132 GPU Attributes: (INFO) 2017-06-29 22:54:37,116 browser._LogBrowserInfo:134 amd_switchable : False (INFO) 2017-06-29 22:54:37,116 browser._LogBrowserInfo:134 basic_info_state : 1 (INFO) 2017-06-29 22:54:37,116 browser._LogBrowserInfo:134 context_info_state : 1 (INFO) 2017-06-29 22:54:37,116 browser._LogBrowserInfo:134 direct_rendering : True (INFO) 2017-06-29 22:54:37,116 browser._LogBrowserInfo:134 driver_date : 2017/04/07 (INFO) 2017-06-29 22:54:37,116 browser._LogBrowserInfo:134 driver_vendor : Google Inc. (INFO) 2017-06-29 22:54:37,116 browser._LogBrowserInfo:134 driver_version : 3.3.0.2 (INFO) 2017-06-29 22:54:37,116 browser._LogBrowserInfo:134 gl_extensions : (INFO) 2017-06-29 22:54:37,116 browser._LogBrowserInfo:134 gl_renderer : Google SwiftShader (INFO) 2017-06-29 22:54:37,116 browser._LogBrowserInfo:134 gl_reset_notification_strategy: 0 (INFO) 2017-06-29 22:54:37,116 browser._LogBrowserInfo:134 gl_vendor : Google Inc. (INFO) 2017-06-29 22:54:37,116 browser._LogBrowserInfo:134 gl_version : OpenGL ES 2.0 SwiftShader (INFO) 2017-06-29 22:54:37,117 browser._LogBrowserInfo:134 gl_ws_extensions : GLX_ARB_create_context GLX_ARB_create_context_profile GLX_ARB_create_context_robustness GLX_ARB_fbconfig_float GLX_ARB_framebuffer_sRGB GLX_ARB_multisample GLX_EXT_create_context_es2_profile GLX_EXT_framebuffer_sRGB GLX_EXT_import_context GLX_EXT_texture_from_pixmap GLX_EXT_visual_info GLX_EXT_visual_rating GLX_MESA_copy_sub_buffer GLX_OML_swap_method GLX_SGI_swap_control GLX_SGIS_multisample GLX_SGIX_fbconfig GLX_SGIX_pbuffer GLX_SGIX_visual_select_group GLX_INTEL_swap_event (INFO) 2017-06-29 22:54:37,117 browser._LogBrowserInfo:134 gl_ws_vendor : SGI (INFO) 2017-06-29 22:54:37,117 browser._LogBrowserInfo:134 gl_ws_version : 1.4 (INFO) 2017-06-29 22:54:37,117 browser._LogBrowserInfo:134 hdr : False (INFO) 2017-06-29 22:54:37,117 browser._LogBrowserInfo:134 in_process_gpu : False (INFO) 2017-06-29 22:54:37,117 browser._LogBrowserInfo:134 initialization_time : 0.083146 (INFO) 2017-06-29 22:54:37,117 browser._LogBrowserInfo:134 jpeg_decode_accelerator_supported: False (INFO) 2017-06-29 22:54:37,117 browser._LogBrowserInfo:134 max_msaa_samples : 4 (INFO) 2017-06-29 22:54:37,117 browser._LogBrowserInfo:134 optimus : False (INFO) 2017-06-29 22:54:37,117 browser._LogBrowserInfo:134 passthrough_cmd_decoder: False (INFO) 2017-06-29 22:54:37,117 browser._LogBrowserInfo:134 pixel_shader_version: 3.0 (INFO) 2017-06-29 22:54:37,117 browser._LogBrowserInfo:134 process_crash_count : 0 (INFO) 2017-06-29 22:54:37,117 browser._LogBrowserInfo:134 rgba_visual : 95 (INFO) 2017-06-29 22:54:37,117 browser._LogBrowserInfo:134 sandboxed : True (INFO) 2017-06-29 22:54:37,117 browser._LogBrowserInfo:134 software_rendering : True (INFO) 2017-06-29 22:54:37,117 browser._LogBrowserInfo:134 supports_overlays : False (INFO) 2017-06-29 22:54:37,118 browser._LogBrowserInfo:134 system_visual : 32 (INFO) 2017-06-29 22:54:37,118 browser._LogBrowserInfo:134 vertex_shader_version: 3.0 (INFO) 2017-06-29 22:54:37,118 browser._LogBrowserInfo:134 video_decode_accelerator_flags: 0 (INFO) 2017-06-29 22:54:37,118 browser._LogBrowserInfo:136 Feature Status: (INFO) 2017-06-29 22:54:37,118 browser._LogBrowserInfo:138 2d_canvas : unavailable_software (INFO) 2017-06-29 22:54:37,118 browser._LogBrowserInfo:138 checker_imaging : enabled_on (INFO) 2017-06-29 22:54:37,118 browser._LogBrowserInfo:138 flash_3d : unavailable_software (INFO) 2017-06-29 22:54:37,118 browser._LogBrowserInfo:138 flash_stage3d : unavailable_software (INFO) 2017-06-29 22:54:37,118 browser._LogBrowserInfo:138 flash_stage3d_baseline: unavailable_software (INFO) 2017-06-29 22:54:37,118 browser._LogBrowserInfo:138 gpu_compositing : unavailable_software (INFO) 2017-06-29 22:54:37,118 browser._LogBrowserInfo:138 multiple_raster_threads: enabled_on (INFO) 2017-06-29 22:54:37,118 browser._LogBrowserInfo:138 native_gpu_memory_buffers: disabled_software (INFO) 2017-06-29 22:54:37,118 browser._LogBrowserInfo:138 rasterization : unavailable_software (INFO) 2017-06-29 22:54:37,119 browser._LogBrowserInfo:138 video_decode : unavailable_software (INFO) 2017-06-29 22:54:37,119 browser._LogBrowserInfo:138 video_encode : unavailable_software (INFO) 2017-06-29 22:54:37,119 browser._LogBrowserInfo:138 webgl : enabled_readback (INFO) 2017-06-29 22:54:37,119 browser._LogBrowserInfo:138 webgl2 : unavailable_off (INFO) 2017-06-29 22:54:37,119 browser._LogBrowserInfo:140 Driver Bug Workarounds: (INFO) 2017-06-29 22:54:37,119 browser._LogBrowserInfo:142 adjust_src_dst_region_for_blitframebuffer (INFO) 2017-06-29 22:54:37,119 browser._LogBrowserInfo:142 clear_uniforms_before_first_program_use (INFO) 2017-06-29 22:54:37,119 browser._LogBrowserInfo:142 disable_chromium_framebuffer_multisample (INFO) 2017-06-29 22:54:37,119 browser._LogBrowserInfo:142 disable_framebuffer_cmaa (INFO) 2017-06-29 22:54:37,119 browser._LogBrowserInfo:142 msaa_is_slow (INFO) 2017-06-29 22:54:37,119 browser._LogBrowserInfo:142 scalarize_vec_and_mat_constructor_args (INFO) 2017-06-29 22:54:37,302 ts_proxy_server._IssueCommand:93 Issuing command to ts_proxy_server: set rtt 0 (INFO) 2017-06-29 22:54:37,302 ts_proxy_server._IssueCommand:93 Issuing command to ts_proxy_server: set inkbps 0 (INFO) 2017-06-29 22:54:37,303 ts_proxy_server._IssueCommand:93 Issuing command to ts_proxy_server: set outkbps 0 (INFO) 2017-06-29 22:54:37,303 cache_temperature.EnsurePageCacheTemperature:54 PageCacheTemperature: any (INFO) 2017-06-29 22:55:10,131 browser.DumpStateUponFailure:372 *************** BROWSER STANDARD OUTPUT *************** (INFO) 2017-06-29 22:55:10,131 browser.DumpStateUponFailure:374 [22549:22562:0629/225435.736457:WARNING:file_path_watcher_linux.cc(626)] Watch failed for /etc/../run/resolvconf: No space left on device [22549:22595:0629/225436.035143:ERROR:devtools_http_handler.cc(804)] DevTools listening on 127.0.0.1:59568 [22549:22567:0629/225436.931731:ERROR:cert_verify_proc_nss.cc(902)] CERT_PKIXVerifyCert for www.gstatic.com failed err=-8172 [22549:22566:0629/225437.531533:ERROR:cert_verify_proc_nss.cc(902)] CERT_PKIXVerifyCert for www.facebook.com failed err=-8172 [22549:22572:0629/225437.605509:WARNING:simple_synchronous_entry.cc(1102)] Could not open platform files for entry. [22549:22567:0629/225437.765796:ERROR:cert_verify_proc_nss.cc(902)] CERT_PKIXVerifyCert for static.xx.fbcdn.net failed err=-8172 [22549:22566:0629/225440.287797:ERROR:cert_verify_proc_nss.cc(902)] CERT_PKIXVerifyCert for scontent-mrs1-1.xx.fbcdn.net failed err=-8172 [22549:22567:0629/225441.004307:ERROR:cert_verify_proc_nss.cc(902)] CERT_PKIXVerifyCert for fbcdn-photos-c-a.akamaihd.net failed err=-8172 [22549:22566:0629/225442.053519:ERROR:cert_verify_proc_nss.cc(902)] CERT_PKIXVerifyCert for fbcdn-photos-a-a.akamaihd.net failed err=-8172 [22549:22567:0629/225442.146174:ERROR:cert_verify_proc_nss.cc(902)] CERT_PKIXVerifyCert for fbcdn-photos-f-a.akamaihd.net failed err=-8172 [22549:22566:0629/225442.153050:ERROR:cert_verify_proc_nss.cc(902)] CERT_PKIXVerifyCert for fbcdn-photos-h-a.akamaihd.net failed err=-8172 [22549:22567:0629/225442.649927:ERROR:cert_verify_proc_nss.cc(902)] CERT_PKIXVerifyCert for fbcdn-profile-a.akamaihd.net failed err=-8172 [22549:22549:0629/225444.996496:INFO:CONSOLE(0)] "Access to Script at 'https://static.xx.fbcdn.net/rsrc.php/v2/yJ/r/pUrM6-FKMOd.js' from origin 'https://www.facebook.com' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://www.facebook.com' is therefore not allowed access. The response had HTTP status code 404.", source: https://www.facebook.com/shakira (0) [22549:22566:0629/225445.986337:ERROR:cert_verify_proc_nss.cc(902)] CERT_PKIXVerifyCert for ssl.gstatic.com failed err=-8172 [22549:22567:0629/225458.567795:ERROR:cert_verify_proc_nss.cc(902)] CERT_PKIXVerifyCert for pixel.facebook.com failed err=-8172 (INFO) 2017-06-29 22:55:10,131 browser.DumpStateUponFailure:377 *********** END OF BROWSER STANDARD OUTPUT ************ (INFO) 2017-06-29 22:55:10,131 browser.DumpStateUponFailure:379 ********************* BROWSER LOG ********************* (INFO) 2017-06-29 22:55:10,132 browser.DumpStateUponFailure:381 No log file (INFO) 2017-06-29 22:55:10,132 browser.DumpStateUponFailure:384 ***************** END OF BROWSER LOG ****************** Traceback (most recent call last): File "/home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 107, in _RunStoryAndProcessErrorIfNeeded state.RunStory(results) File "/home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function return func(*args, **kwargs) File "/home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 305, in RunStory self._current_page.Run(self) File "/home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/third_party/catapult/telemetry/telemetry/page/__init__.py", line 112, in Run self.RunPageInteractions(action_runner) File "/home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/tools/perf/page_sets/system_health/system_health_story.py", line 142, in RunPageInteractions self._DidLoadDocument(action_runner) File "/home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/tools/perf/page_sets/system_health/browsing_stories.py", line 808, in _DidLoadDocument self._Scroll(action_runner, self.SCROLL_DISTANCE, self.SCROLL_STEP) File "/home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/tools/perf/page_sets/system_health/browsing_stories.py", line 830, in _Scroll 'Scrolling stuck at %d' % remaining) StoryActionError: Scrolling stuck at 20878 (INFO) 2017-06-29 22:55:10,846 chrome_tracing_agent.RecordClockSyncMarker:182 Chrome version: 3143 (INFO) 2017-06-29 22:55:20,573 trace_data.Serialize:189 Trace sizes in bytes: {'cpuSnapshots': 3499563, 'traceEvents': 16584065, 'telemetry': 157477, 'tabIds': 40} [ FAILED ] browse:social:facebook_infinite_scroll@{'case': 'browse', 'group': 'social'} (51635 ms) (INFO) 2017-06-29 22:55:26,454 cloud_storage.Insert:377 Uploading /tmp/tmpvSjkpC.html to gs://chrome-telemetry-output/trace-file-id_1-2017-06-29_22-55-26-1098.html (ERROR) 2017-06-29 22:55:27,960 trace.UploadToCloud:161 Cannot upload trace files to cloud storage due to permission error: Attempted to access a file from Cloud Storage but you don't have permission. To configure your credentials: 1. Run "/home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/third_party/catapult/third_party/gsutil/gsutil config" and follow its instructions. 2. If you have a @google.com account, use that account. 3. For the project-id, just enter 0. (INFO) 2017-06-29 22:55:27,961 cloud_storage.Insert:377 Uploading /tmp/tmpP9fOJJ.png to gs://chrome-telemetry-output/profiler-file-id_0-2017-06-29_22-55-2784397.png (ERROR) 2017-06-29 22:55:28,869 page_test_results.UploadProfilingFilesToCloud:427 Cannot upload profiling files to cloud storage due to permission error: Attempted to access a file from Cloud Storage but you don't have permission. To configure your credentials: 1. Run "/home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/third_party/catapult/third_party/gsutil/gsutil config" and follow its instructions. 2. If you have a @google.com account, use that account. 3. For the project-id, just enter 0. [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] browse:social:facebook_infinite_scroll@{'case': 'browse', 'group': 'social'} 1 FAILED TEST View result at file:///home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/tools/perf/results-chart.json
,
Jun 29 2017
result of file:///home/ajithk/EXTRA_HDD/ANDROID_BROWSER/LINUX-CHROMIUM/src/tools/perf/results-chart.json is as follows;
{
"trace_rerun_options": [],
"benchmark_metadata": {
"rerun_options": [],
"type": "telemetry_benchmark",
"name": "system_health.common_desktop",
"description": "Desktop Chrome Energy System Health Benchmark."
},
"format_version": "0.1",
"benchmark_description": "Desktop Chrome Energy System Health Benchmark.",
"enabled": true,
"charts": {
"benchmark_duration": {
"summary": {
"units": "minutes",
"important": true,
"type": "scalar",
"name": "benchmark_duration",
"value": 0.9503551165262858
}
},
"trace": {
"browse:social:facebook_infinite_scroll": {
"name": "trace",
"type": "trace",
"grouping_keys": {
"case": "browse",
"group": "social"
},
"important": false,
"units": "",
"tir_label": "browse_social",
"page_id": 3
}
}
},
"next_version": "0.2",
"benchmark_name": "system_health.common_desktop"
}
I am not able to make out anything from above results. Could you please help me to understand further ?
From #12 - Does the test ran correctly or not ? or any more permission is needed further ?
,
Jun 29 2017
,
Jun 30 2017
,
Jul 5 2017
kochi@ - I applied a probable fix @ and results of performance bot is available @ https://00e9e64bacc7982ae6c7c0705bfef55de0bf263b2408a96141-apidata.googleusercontent.com/download/storage/v1/b/chromium-telemetry/o/html-results%2Fresults-2017-07-04_09-45-18?qk=AD5uMEsrJRGYXIPfAu7idXQ6KlHnZZU3zgaDGSwTEeIdAL7mDmFJ_g7-YDXM9DzLlq6Teb4GUskwGa-uiDeWpWpvob4m4cZjfMPnRpJnI0eIFc22EW6ZREpT3rnszLZZH3K1q6lXi1Apqf_Q5bKEnp2pzwNLcKd_Wf9_1sS5agQgudPx2-SBnGwA-yBPHndEFrKql7GJb4iJy1l8vGzV_KHlgjd6eKbllL7zc_R38EkIZty4WBPtYXdYUtzgpHA1w6jN7prqgsfza0oAZM35zL2lsJ4iEt6-7bJIJqhan6ljmwc4sCAgTrjW1P5AhbiopMnwrOYypRMwhz046DxiME5iKuqCMx08Ete7eRms9jXlIIrep_UHoydn2nPh6bCa5ccS1avcrMERI5mBREgeqhDNfMoj4Rhvelg8sa0tHkSdVt8YI9AcwqlTMqFpAA9gfvqQJlnsIPCkEXfZeeT_TBtYi4Mwsu5kOyy5p8x5Hd04C7Yzr-YLEzPLAIqLU7VWu7ZN0v56rF8woVf4WkUnnXpRt_Y8iGEE74qw5udw1hVAgh-kxRiAJFlfpb0-ZwznCEEV6MKq0b9NeHig0W7CK3l3RdO5fXBB-1H8TkUJDz2o6qhjsV6DiZCoGtFjd1Td9W10VYXJbF0FLi4ypTogMtJJYZQLOKvmDHduvb29Ws-1lAwv8gNu_XlGg8jT-MjeMW_BYdaJxEsdRG99lF6bkqvIAn9f-Dey2cqXhN5wJdfM5qiCgDoQ3ZIn-DoFd3aGytGH2sFyJdjJVNCX5r0G3rbJTZQTkfsCQKeiGGrxdoc_BiT76HTpzrsz2FWIm07Z-zELo7g2k749 But all values showing insignificant regression or insignificant improvement. Could you please help me to interpret the results.
,
Jul 5 2017
Probable patch is @ https://codereview.chromium.org/2926023002/
,
Jul 10 2017
,
Jul 13 2017
When I ran the test locally on linux chrome build, with initial regressed patch, result is as follows; cpu_time_percentage 137.359% 135.554% Indicates, it's improvement, not regression
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/041c0b075176fb9bca94fd67fc1b6053a4df2e1c commit 041c0b075176fb9bca94fd67fc1b6053a4df2e1c Author: AJITH KUMAR V <ajith.v@samsung.com> Date: Tue Aug 08 10:39:20 2017 [Android] Relanding Smart GO NEXT feature in Android Chrome 2/2 This is second patch of Smart GO NEXT feature. Initial patch is landed @ https://codereview.chromium.org/2967493002/ Design Document: https://docs.google.com/document/d/1h0diigZ8LUi7A3UKJ_zwNUbvNQoe-Nwr55_p6ivSPNg/edit?usp=sharing Performance regression is getting tackled using the triggering of Focus Controller call only if element focus is changed, otherwise continue to use previously cached value. This will save unwanted tree traversal in every frame update. BUG= 410785 , 648986 , 733222 , 737388 Change-Id: Ib2c7343a6ec7dea18c7cfa5ac283ac4d29e3a4cb Reviewed-on: https://chromium-review.googlesource.com/574514 Commit-Queue: AJITH KUMAR V <ajith.v@samsung.com> Reviewed-by: Changwan Ryu <changwan@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#492588} [modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/content/public/android/javatests/src/org/chromium/content/browser/input/ImeActivityTestRule.java [modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java [modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java [modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/content/renderer/render_widget.cc [modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/content/renderer/render_widget.h [modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/content/test/data/android/input/input_forms.html [modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/third_party/WebKit/Source/core/editing/InputMethodController.cpp [modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/third_party/WebKit/Source/core/editing/InputMethodController.h [modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/third_party/WebKit/Source/core/exported/WebInputMethodControllerImpl.cpp [modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/third_party/WebKit/Source/core/exported/WebInputMethodControllerImpl.h [modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/third_party/WebKit/Source/core/exported/WebViewTest.cpp [add] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/third_party/WebKit/Source/core/testing/data/advance_focus_in_form_with_disabled_and_readonly_elements.html [add] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/third_party/WebKit/Source/core/testing/data/advance_focus_in_form_with_key_event_listeners.html [add] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/third_party/WebKit/Source/core/testing/data/advance_focus_in_form_with_tabindex_elements.html [modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/third_party/WebKit/public/web/WebInputMethodController.h
,
Aug 8 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by sullivan@chromium.org
, Jun 28 2017