New issue
Advanced search Search tips

Issue 737360 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: 2017-07-06
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

6.3% regression in system_health.memory_mobile at 482302:482366

Project Member Reported by sullivan@chromium.org, Jun 28 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=737360

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrouCogsM


Bot(s) for this bug's original alert(s):

android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 28 2017

Cc: vmp...@chromium.org
Owner: vmp...@chromium.org

=== Auto-CCing suspected CL author vmpstr@chromium.org ===

Hi vmpstr@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Vladimir Levin
  Commit : aee539101b28c16fc9e38fe648ab0f5d017c4aab
  Date   : Mon Jun 26 17:34:44 2017
  Subject: cc: Add solid color analyzer to replace AnalysisCanvas

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:cc:effective_size_avg/load_news/load_news_irctc
  Change       : 5.89% | 86612085.3333 -> 91710408.0

Revision             Result                   N
chromium@482301      86612085 +- 882508       6      good
chromium@482304      86631883 +- 2057337      6      good
chromium@482305      91447565 +- 2261937      6      bad       <--
chromium@482306      91070344 +- 2111016      6      bad
chromium@482310      91531112 +- 1082387      6      bad
chromium@482318      92046909 +- 2111812      6      bad
chromium@482334      91238680 +- 1729598      6      bad
chromium@482366      91710408 +- 3796104      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.irctc system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8975583694408286304

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6351933532536832


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jun 28 2017

Issue 737262 has been merged into this issue.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jun 28 2017

 Issue 737362  has been merged into this issue.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Jun 28 2017

Issue 737263 has been merged into this issue.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Jun 28 2017

 Issue 737380  has been merged into this issue.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Jun 28 2017

Cc: perezju@chromium.org
 Issue 737517  has been merged into this issue.
Issue 737550 has been merged into this issue.
vmpstr, do you have a plan to address this regressions shortly? The course of action otherwise will be to revert your CL while you can continue investigating the issue.
NextAction: 2017-07-06
The NextAction date has arrived: 2017-07-06
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.
vmpstr: ping? thi sis a pretty big memory regression.
vmpstr: Is there anything that can be done about this now?
I'm really sorry this slipped off my radar, I'll take a look at this asap.
Cc: sunxd@chromium.org
Status: Fixed (was: Assigned)
It looks like the regression was 5MB. Since landing this, we have added more functionality that was previously handled by the analysis canvas. Specifically, https://chromium.googlesource.com/chromium/src/+/71fe8359e1fff12a6bec2384a83b6440bca62b55 landed which handled more common ops and seemed to have recovered this regression (~5MB improvement)

Sign in to add a comment