Increase minimum space UI requires for migration to 50MB |
||||
Issue descriptionIn the event the user has insufficient disk space to begin the migration, return a low disk space error which should indicate that the UI should show the low disk space UI, not delete the profile.
,
Jun 29 2017
One way to clear up space without logging in to a profile is evicting (automatically, or after asking the user) cache files. Also, we can remove profiles which haven't been touched for long when there are many profile on a device (which can happen frequently in school classes).
,
Jun 29 2017
The cleanup code that does this is already run at boot time (on low disk situations) before the crypto migration, so we should have all this low-hanging fruit cleared already. It is possible that the user booted and first logged in to (and filled up) one profile then switched to another to migrate, in which case this could be helpful.
,
Jun 30 2017
After talking with fukino@ we decided that raising the minimum space requirements in the UI to 50MB should cover almost all cases (up to about 10k folders) with minimal effort. There's still the possibility of a user have an excessive number of folders hitting this and getting their profile wiped, but it should be extremely rare.
,
Jun 30 2017
,
Jul 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55067bd6ae2557dd1ca2ef1dcf796fe7d2175456 commit 55067bd6ae2557dd1ca2ef1dcf796fe7d2175456 Author: dspaid <dspaid@chromium.org> Date: Mon Jul 03 04:33:55 2017 Update minimum space for migration to 50MB Users with large numbers of directories may require more space overhead as any given directory tree may be duplicated on both source and destination. Increase the minimum migration storage space to account for this. BUG= 737343 TEST=Fill disk and attempt to migrate Review-Url: https://codereview.chromium.org/2968643002 Cr-Commit-Position: refs/heads/master@{#483940} [modify] https://crrev.com/55067bd6ae2557dd1ca2ef1dcf796fe7d2175456/chrome/browser/chromeos/arc/arc_migration_constants.h
,
Jul 28 2017
Is this Fixed? Any need to merge this ?
,
Jul 28 2017
No need to merge, M61 is fine. No additional work needed.
,
Jan 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dspaid@chromium.org
, Jun 28 2017