Size of the new note icon in the system tray for lock screen apps should be 16 px |
|||
Issue descriptionThe icon size is 16 dip, but the svg resource for the icon is 20 dip. We should update the resource to match the icon size. can I please get 16px/32px versions of the icon? Or I can alternatively use instructions at https://www.chromium.org/developers/how-tos/vectorized-icons-in-native-chrome-ui to scale the existing resource down (since we might be switching to new UI for the entry point either way - https://bugs.chromium.org/p/chromium/issues/detail?id=737067).
,
Jun 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb97d866ca2ba77f826975a13524eae76839c37a commit fb97d866ca2ba77f826975a13524eae76839c37a Author: tbarzic <tbarzic@chromium.org> Date: Wed Jun 28 23:31:22 2017 Fixup icon for new lock screen note action item * Use correctly sized icon - 16 dip vs 20 dip * Remove uneeded NewNoteActionView wrapper around the icon, and instead use ImageView directly. BUG= 737338 , 725130 Review-Url: https://codereview.chromium.org/2956383002 Cr-Commit-Position: refs/heads/master@{#483189} [modify] https://crrev.com/fb97d866ca2ba77f826975a13524eae76839c37a/ash/resources/vector_icons/BUILD.gn [add] https://crrev.com/fb97d866ca2ba77f826975a13524eae76839c37a/ash/resources/vector_icons/tray_action_new_lock_screen_note.1x.icon [add] https://crrev.com/fb97d866ca2ba77f826975a13524eae76839c37a/ash/resources/vector_icons/tray_action_new_lock_screen_note.icon [modify] https://crrev.com/fb97d866ca2ba77f826975a13524eae76839c37a/ash/system/lock_screen_action/lock_screen_action_tray.cc [modify] https://crrev.com/fb97d866ca2ba77f826975a13524eae76839c37a/ash/system/lock_screen_action/lock_screen_action_tray.h
,
Jun 29 2017
Please check the assets here. They are in 16dp-1x and 32dp-2x. https://drive.google.com/open?id=0B_2Uyb2Rhx2ONE5ZWDVUeFRVdHM
,
Jul 5 2017
,
Jan 22 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tdander...@chromium.org
, Jun 28 2017