New issue
Advanced search Search tips

Issue 737326 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"cronet_unittests" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 28 2017

Issue description

"cronet_unittests" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyGwsSBUZsYWtlIhBjcm9uZXRfdW5pdHRlc3RzDA.

The chromium-try-flakes app is able to file bugs for individual tests when the test launcher is uploading results to the Test Results Server. If recent flakes above are caused by failing tests and you would like to have them filed as invidual bugs, please read more at https://goo.gl/QJKXV4.
 
Owner: mmenke@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88889c61f7ea672abc0a2c40c3f94457e1812107

commit 88889c61f7ea672abc0a2c40c3f94457e1812107
Author: benwells <benwells@chromium.org>
Date: Wed Jun 28 08:29:59 2017

Disabled three flaky cronet tests.

TBR=mmenke@chromium.org
BUG= 737326 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2955973008
Cr-Commit-Position: refs/heads/master@{#482919}

[modify] https://crrev.com/88889c61f7ea672abc0a2c40c3f94457e1812107/components/cronet/stale_host_resolver_unittest.cc
[modify] https://crrev.com/88889c61f7ea672abc0a2c40c3f94457e1812107/components/cronet/url_request_context_config_unittest.cc

Labels: -Sheriff-Chromium

Comment 4 by mmenke@chromium.org, Jun 28 2017

Cc: mmenke@chromium.org
 Issue 737417  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51629db1e4abd11d33150d7fc0a2207c0fc5cd9c

commit 51629db1e4abd11d33150d7fc0a2207c0fc5cd9c
Author: mmenke <mmenke@chromium.org>
Date: Wed Jun 28 13:34:12 2017

Fix Cronet tests.

These were broken when URLRequestContextBuilder was switched over to
using task_scheduler by default in
https://codereview.chromium.org/2951813002/.

The fix is to instantiate a base::test::ScopedTaskEnvironment instead
of a MessageLoopForIO.

BUG= 715695 , 737326 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2963643002
Cr-Commit-Position: refs/heads/master@{#482965}

[modify] https://crrev.com/51629db1e4abd11d33150d7fc0a2207c0fc5cd9c/components/cronet/stale_host_resolver_unittest.cc
[modify] https://crrev.com/51629db1e4abd11d33150d7fc0a2207c0fc5cd9c/components/cronet/url_request_context_config_unittest.cc

Comment 6 by mmenke@chromium.org, Jun 28 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment