New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737323 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Upgrade Opus to v1.2.1

Project Member Reported by flim@chromium.org, Jun 28 2017

Issue description

Comment 1 by flim@chromium.org, Jul 13 2017

This update causes two tests from cast_unittests to fail with the error messages given below. These look to be due to tight constraints on the validity of the decoded signals, as can be seen in attached plots, and can probably be relaxed. 

---

[ RUN      ] AudioDecoderTestScenarios/AudioDecoderTest.DecodesFramesWithVaryingDuration/2
../../media/cast/receiver/audio_decoder_unittest.cc:175: Failure
The difference between TestAudioBusFactory::kMiddleANoteFreq * 2 * audio_bus->frames() / GetParam().sampling_rate and CountZeroCrossings(audio_bus->channel(ch), audio_bus->frames()) is 2, which exceeds 1, where
TestAudioBusFactory::kMiddleANoteFreq * 2 * audio_bus->frames() / GetParam().sampling_rate evaluates to 4,
CountZeroCrossings(audio_bus->channel(ch), audio_bus->frames()) evaluates to 2, and
1 evaluates to 1.
[  FAILED  ] AudioDecoderTestScenarios/AudioDecoderTest.DecodesFramesWithVaryingDuration/2, where GetParam() = 12-byte object <01-00 00-00 01-00 00-00 40-1F 00-00> (37 ms)

---

[ RUN      ] AudioDecoderTestScenarios/AudioDecoderTest.RecoversFromDroppedFrames/2
../../media/cast/receiver/audio_decoder_unittest.cc:175: Failure
The difference between TestAudioBusFactory::kMiddleANoteFreq * 2 * audio_bus->frames() / GetParam().sampling_rate and CountZeroCrossings(audio_bus->channel(ch), audio_bus->frames()) is 2, which exceeds 1, where
TestAudioBusFactory::kMiddleANoteFreq * 2 * audio_bus->frames() / GetParam().sampling_rate evaluates to 8,
CountZeroCrossings(audio_bus->channel(ch), audio_bus->frames()) evaluates to 6, and
1 evaluates to 1.
[  FAILED  ] AudioDecoderTestScenarios/AudioDecoderTest.RecoversFromDroppedFrames/2, where GetParam() = 12-byte object <01-00 00-00 01-00 00-00 40-1F 00-00> (25 ms)

DecodesFramesWithVaryingDuration.jpg
35.8 KB View Download
RecoversFromDroppedFrames.jpg
58.9 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b5dc578114a5237748e6b3da5cbef19a5e75e17

commit 0b5dc578114a5237748e6b3da5cbef19a5e75e17
Author: flim <flim@chromium.org>
Date: Fri Jul 21 04:35:44 2017

[Opus] Update to v1.2.1

BUG= 737323 

Review-Url: https://codereview.chromium.org/2962373002
Cr-Commit-Position: refs/heads/master@{#488582}

[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/media/cast/receiver/audio_decoder_unittest.cc
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/media/cast/test/utility/audio_utility.cc
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/WebKit/LayoutTests/webaudio/codec-tests/opus/opus-decode-expected.wav
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/BUILD.gn
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/DEPS
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/README.chromium
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/LICENSE_PLEASE_READ.txt
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/Makefile.am
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/Makefile.mips
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/Makefile.unix
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/README
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/README.draft
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/autogen.sh
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/_kiss_fft_guts.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/arch.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/arm/arm2gnu.pl
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/arm/arm_celt_map.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/arm/celt_ne10_fft.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/arm/celt_neon_intr.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/arm/celt_pitch_xcorr_arm.s
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/arm/fft_arm.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/arm/fixed_armv4.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/arm/fixed_armv5e.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/arm/mdct_arm.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/arm/pitch_arm.h
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/arm/pitch_neon_intr.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/bands.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/bands.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/celt.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/celt.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/celt_decoder.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/celt_encoder.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/celt_lpc.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/celt_lpc.h
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/dump_modes/dump_modes.c
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/dump_modes/dump_modes_arch.h
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/dump_modes/dump_modes_arm_ne10.c
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/fixed_c5x.h
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/fixed_c6x.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/fixed_debug.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/fixed_generic.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/float_cast.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/kiss_fft.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/mathops.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/mdct.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/mips/vq_mipsr1.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/modes.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/pitch.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/pitch.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/quant_bands.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/rate.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/static_modes_fixed_arm_ne10.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/static_modes_float_arm_ne10.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/tests/test_unit_dft.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/tests/test_unit_mathops.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/tests/test_unit_mdct.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/tests/test_unit_rotation.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/vq.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/vq.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/x86/celt_lpc_sse.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/x86/celt_lpc_sse.h
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/x86/vq_sse.h
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/x86/vq_sse2.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/celt/x86/x86_celt_map.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/configure.ac
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/doc/Doxyfile.in
[delete] https://crrev.com/40e9e5f0a1a32bea870e6f0271c97c44f12666b8/third_party/opus/src/doc/TODO
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/doc/build_draft.sh
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/doc/build_isobmff.sh
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/doc/build_oggdraft.sh
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/doc/draft-ietf-codec-oggopus.xml
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/doc/draft-ietf-codec-opus-update.xml
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/doc/draft-ietf-codec-opus.xml
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/doc/draft-ietf-payload-rtp-opus.xml
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/doc/opus_in_isobmff.css
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/doc/opus_in_isobmff.html
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/doc/opus_update.patch
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/doc/release.txt
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/include/opus_defines.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/include/opus_multistream.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/include/opus_types.h
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/releases.sha2
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/A2NLSF.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/CNG.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/LPC_analysis_filter.c
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/LPC_fit.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/LPC_inv_pred_gain.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/LP_variable_cutoff.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/MacroCount.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/MacroDebug.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/NLSF2A.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/NLSF_VQ.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/NLSF_decode.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/NLSF_del_dec_quant.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/NLSF_encode.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/NSQ.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/NSQ_del_dec.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/PLC.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/SigProc_FIX.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/VQ_WMat_EC.c
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/arm/LPC_inv_pred_gain_arm.h
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/arm/LPC_inv_pred_gain_neon_intr.c
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/arm/NSQ_del_dec_arm.h
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/arm/NSQ_del_dec_neon_intr.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/arm/NSQ_neon.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/arm/arm_silk_map.c
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/arm/biquad_alt_arm.h
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/arm/biquad_alt_neon_intr.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/arm/macros_armv4.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/arm/macros_armv5e.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/biquad_alt.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/bwexpander.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/control.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/control_SNR.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/control_codec.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/debug.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/decode_core.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/decode_frame.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/decode_parameters.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/define.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/enc_API.c
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/arm/warped_autocorrelation_FIX_arm.h
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/arm/warped_autocorrelation_FIX_neon_intr.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/burg_modified_FIX.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/corrMatrix_FIX.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/encode_frame_FIX.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/find_LPC_FIX.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/find_LTP_FIX.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/find_pitch_lags_FIX.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/find_pred_coefs_FIX.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/k2a_FIX.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/k2a_Q16_FIX.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/main_FIX.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/mips/noise_shape_analysis_FIX_mipsr1.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/mips/warped_autocorrelation_FIX_mipsr1.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/noise_shape_analysis_FIX.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/pitch_analysis_core_FIX.c
[delete] https://crrev.com/40e9e5f0a1a32bea870e6f0271c97c44f12666b8/third_party/opus/src/silk/fixed/prefilter_FIX.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/schur64_FIX.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/schur_FIX.c
[delete] https://crrev.com/40e9e5f0a1a32bea870e6f0271c97c44f12666b8/third_party/opus/src/silk/fixed/solve_LS_FIX.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/structs_FIX.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/warped_autocorrelation_FIX.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/fixed/x86/prefilter_FIX_sse.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/float/LPC_inv_pred_gain_FLP.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/float/SigProc_FLP.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/float/encode_frame_FLP.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/float/energy_FLP.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/float/find_LPC_FLP.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/float/find_LTP_FLP.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/float/find_pred_coefs_FLP.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/float/inner_product_FLP.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/float/k2a_FLP.c
[delete] https://crrev.com/40e9e5f0a1a32bea870e6f0271c97c44f12666b8/third_party/opus/src/silk/float/levinsondurbin_FLP.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/float/main_FLP.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/float/noise_shape_analysis_FLP.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/float/pitch_analysis_core_FLP.c
[delete] https://crrev.com/40e9e5f0a1a32bea870e6f0271c97c44f12666b8/third_party/opus/src/silk/float/prefilter_FLP.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/float/schur_FLP.c
[delete] https://crrev.com/40e9e5f0a1a32bea870e6f0271c97c44f12666b8/third_party/opus/src/silk/float/solve_LS_FLP.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/float/structs_FLP.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/float/wrappers_FLP.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/gain_quant.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/init_decoder.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/lin2log.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/macros.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/main.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/mips/NSQ_del_dec_mipsr1.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/mips/sigproc_fix_mipsr1.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/process_NLSFs.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/quant_LTP_gains.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/structs.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/sum_sqr_shift.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/tables.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/tables_LTP.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/tables_NLSF_CB_NB_MB.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/tables_NLSF_CB_WB.c
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/tests/test_unit_LPC_inv_pred_gain.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/tuning_parameters.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/x86/NSQ_del_dec_sse.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/x86/NSQ_sse.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/x86/main_sse.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/silk/x86/x86_silk_map.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/src/analysis.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/src/analysis.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/src/mlp_data.c
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/src/mlp_train.c
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/src/mlp_train.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/src/opus.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/src/opus_compare.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/src/opus_decoder.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/src/opus_demo.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/src/opus_encoder.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/src/opus_multistream_decoder.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/src/opus_multistream_encoder.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/src/opus_private.h
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/tests/opus_decode_fuzzer.c
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/tests/opus_decode_fuzzer.options
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/tests/opus_encode_regressions.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/tests/run_vectors.sh
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/tests/test_opus_api.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/tests/test_opus_common.h
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/tests/test_opus_decode.c
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/tests/test_opus_encode.c
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/update_version
[add] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/win32/.gitignore
[modify] https://crrev.com/0b5dc578114a5237748e6b3da5cbef19a5e75e17/third_party/opus/src/win32/genversion.bat

These appears to break on arm with neon disabled:

gn gen out_opus/ --args='target_cpu="arm" arm_use_neon=false'

ninja -C out_opus/ opus

../../third_party/opus/src/celt/arm/arm_celt_map.c:64:17: error: use of undeclared identifier 'arch'
  MAY_HAVE_NEON(celt_pitch_xcorr)   /* NEON */
                ^
../../third_party/opus/src/celt/arm/pitch_arm.h:93:54: note: expanded from macro 'celt_pitch_xcorr'
#   define celt_pitch_xcorr (*CELT_PITCH_XCORR_IMPL[(arch)&OPUS_ARCHMASK])
                                                     ^
../../third_party/opus/src/celt/arm/arm_celt_map.c:64:3: error: pasting formed ')_media', an invalid preprocessing token
  MAY_HAVE_NEON(celt_pitch_xcorr)   /* NEON */
  ^
../../third_party/opus/src/celt/arm/armcpu.h:46:31: note: expanded from macro 'MAY_HAVE_NEON'
#  define MAY_HAVE_NEON(name) MAY_HAVE_MEDIA(name)
                              ^
../../third_party/opus/src/celt/arm/armcpu.h:38:37: note: expanded from macro 'MAY_HAVE_MEDIA'
#  define MAY_HAVE_MEDIA(name) name ## _media
                                    ^
2 errors generated.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7aad66a92a7e17a205aa3e57487e2fb371d2366c

commit 7aad66a92a7e17a205aa3e57487e2fb371d2366c
Author: flim <flim@chromium.org>
Date: Wed Aug 09 01:05:31 2017

[opus] Update to latest

The corresponding upstream commit hash is 3fe744ea04fdcc418fb85c2c133d13372ebb019b.
This pulls in several fixes including a fix for ARM builds with neon disabled.

Bug:  737323 
Change-Id: I1e0e3f5022d17aa7c16b985ba2bc9253f163576b
Reviewed-on: https://chromium-review.googlesource.com/605970
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Felicia Lim <flim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492797}
[modify] https://crrev.com/7aad66a92a7e17a205aa3e57487e2fb371d2366c/third_party/opus/README.chromium
[modify] https://crrev.com/7aad66a92a7e17a205aa3e57487e2fb371d2366c/third_party/opus/src/celt/arm/pitch_arm.h
[modify] https://crrev.com/7aad66a92a7e17a205aa3e57487e2fb371d2366c/third_party/opus/src/doc/draft-ietf-codec-opus-update.xml
[modify] https://crrev.com/7aad66a92a7e17a205aa3e57487e2fb371d2366c/third_party/opus/src/tests/opus_decode_fuzzer.c

Comment 5 by flim@chromium.org, Aug 28 2017

Status: Fixed (was: Assigned)

Sign in to add a comment