New issue
Advanced search Search tips

Issue 737308 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

gerrit does not automatically add some reviewers from R= line

Project Member Reported by sunn...@chromium.org, Jun 27 2017

Issue description

Whenever I add rsesek as a reviewer using R= in the CL description, git cl upload does not add them as a reviewer. Other folks in the R= line are added correctly.

Example CLs:
https://chromium-review.googlesource.com/c/538056/
https://chromium-review.googlesource.com/c/550962/

git cl upload output has this line:
[W2017-06-27 16:16:21,890 25665 140000162555712 gerrit_util.py] Note: "rsesek" not added as a reviewer



 

Comment 1 by aga...@chromium.org, Jun 28 2017

Status: Started (was: Assigned)
Wow that's fun, and yeah I can reproduce it here: https://chromium-review.googlesource.com/c/553397/

I have no idea why this works for most usernames but not rsesek.

While I try to track this down, you can use the full email address "rsesek@chromium.org" as a workaround, and that should work.

Comment 2 by aga...@chromium.org, Jun 28 2017

The response that gerrit gives when trying to add "rsesek" as a reviewer is
rsesek is not a valid user identifier
which isn't surprising -- what's more surprising is that "sunnyps" *is* a valid user identifier. It's clearly doing some sort of disambiguation when there's only one account with a given username portion or something like that.

I would guess that this is because rsesek has two accounts (one chromium, the other google), and so it doesn't know which to pick. Except that it successfully added alokp and boliu in your second CL, despite them both having two accounts as well.

Comment 3 by aga...@chromium.org, Jun 28 2017

I'm trying to follow up internally here: b/63115075

Comment 4 by aga...@chromium.org, Jun 28 2017

Labels: Milestone-Afterglow Proj-Gerrit-Migration
Status: ExternalDependency (was: Started)
Status: Fixed (was: ExternalDependency)
The internal bug has had a fix landed. I'm going to mark this fixed, though the actual fix likely won't be deployed until early next week.

Sign in to add a comment