gerrit does not automatically add some reviewers from R= line |
|||
Issue descriptionWhenever I add rsesek as a reviewer using R= in the CL description, git cl upload does not add them as a reviewer. Other folks in the R= line are added correctly. Example CLs: https://chromium-review.googlesource.com/c/538056/ https://chromium-review.googlesource.com/c/550962/ git cl upload output has this line: [W2017-06-27 16:16:21,890 25665 140000162555712 gerrit_util.py] Note: "rsesek" not added as a reviewer
,
Jun 28 2017
The response that gerrit gives when trying to add "rsesek" as a reviewer is rsesek is not a valid user identifier which isn't surprising -- what's more surprising is that "sunnyps" *is* a valid user identifier. It's clearly doing some sort of disambiguation when there's only one account with a given username portion or something like that. I would guess that this is because rsesek has two accounts (one chromium, the other google), and so it doesn't know which to pick. Except that it successfully added alokp and boliu in your second CL, despite them both having two accounts as well.
,
Jun 28 2017
I'm trying to follow up internally here: b/63115075
,
Jun 28 2017
,
Jul 5 2017
The internal bug has had a fix landed. I'm going to mark this fixed, though the actual fix likely won't be deployed until early next week. |
|||
►
Sign in to add a comment |
|||
Comment 1 by aga...@chromium.org
, Jun 28 2017