ShowImeIfNeeded just calls OnShowImeIfNeeded, and it just conditionally call ShowKeyboardInternal. Lets replace Ime with Keyboard in the above methods.
IfEnabled instead of IfNeeded maybe more specific and preferred.
<triage> omrilio@ - Could you please triage?
<please triage>
Bulk edit: oka@ is no longer working on virtual keyboard.
Hanada-san, is this something we still want to do?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/539c32ade756a032c20fdc657cc6bc535b8a1379 commit 539c32ade756a032c20fdc657cc6bc535b8a1379 Author: Darren Shen <shend@chromium.org> Date: Tue Jul 03 05:27:43 2018 [VK] Rename ShowImeIfNeeded to ShowVirtualKeyboardIfEnabled. ShowImeIfNeeded shows the virtual keyboard, not IME. Also fix some presubmit issues. TBR=sky@chromium.org, sammc@chromium.org Bug: 737306 Change-Id: I45630beb927af24157681ce2929f6cfd7fe8bf3f Reviewed-on: https://chromium-review.googlesource.com/1121938 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#572118} [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ash/accessibility/accessibility_highlight_controller.h [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ash/magnifier/docked_magnifier_controller.h [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ash/magnifier/magnification_controller.h [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/chrome/browser/chromeos/extensions/default_keyboard_extension_browser_test.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/chrome/browser/chromeos/input_method/textinput_test_helper.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/chrome/browser/chromeos/input_method/textinput_test_helper.h [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/chrome/browser/ui/ash/keyboard_controller_browsertest.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/chrome/browser/ui/search/search_tab_helper.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/chrome/browser/ui/views/find_bar_view.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/chrome/browser/ui/views/omnibox/omnibox_view_views.h [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/components/arc/common/ime.mojom [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/components/arc/ime/arc_ime_bridge.h [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/components/arc/ime/arc_ime_bridge_impl.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/components/arc/ime/arc_ime_bridge_impl.h [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/components/arc/ime/arc_ime_service.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/components/arc/ime/arc_ime_service.h [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/components/arc/ime/arc_ime_service_unittest.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/components/omnibox/browser/omnibox_view.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/components/omnibox/browser/omnibox_view.h [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/content/public/test/text_input_test_utils.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/content/public/test/text_input_test_utils.h [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ui/aura/window_tree_host.h [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ui/base/ime/dummy_input_method.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ui/base/ime/dummy_input_method.h [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ui/base/ime/input_method.h [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ui/base/ime/input_method_base.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ui/base/ime/input_method_base.h [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ui/base/ime/input_method_base_unittest.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ui/base/ime/input_method_observer.h [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ui/base/ime/mock_input_method.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ui/base/ime/mock_input_method.h [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ui/keyboard/keyboard_controller.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ui/keyboard/keyboard_controller.h [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ui/keyboard/keyboard_controller_unittest.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ui/views/controls/textfield/textfield.h [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ui/views/controls/textfield/textfield_unittest.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ui/views/win/hwnd_message_handler.cc [modify] https://crrev.com/539c32ade756a032c20fdc657cc6bc535b8a1379/ui/views/win/hwnd_message_handler.h
Comment 1 by oka@chromium.org
, Jun 27 2017