BlinkIDL parser hangs on file with two declarations without ; between them |
|||
Issue descriptionExample CL: http://crrev.com/c/550902 Adding a semicolon after the CookieChangeType enum moves the parser forward.
,
Jun 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55ef2f2107433cd4c6fd2515b8974e9f16bdded3 commit 55ef2f2107433cd4c6fd2515b8974e9f16bdded3 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Thu Jun 29 03:56:33 2017 IDL parser: Stop using SLR Using SLR has been the root cause of unexpected parser hangs. Looks like performance improvement of using SLR is subtle (only .5 secs on my mac to generate bindings). Stop using SLR to stabilize the parser. BUG= 737302 Change-Id: Id8c7161d302eaa19adb16f8c46c8542eb01b97b6 Reviewed-on: https://chromium-review.googlesource.com/554038 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#483288} [modify] https://crrev.com/55ef2f2107433cd4c6fd2515b8974e9f16bdded3/third_party/WebKit/Source/bindings/scripts/blink_idl_parser.py [add] https://crrev.com/55ef2f2107433cd4c6fd2515b8974e9f16bdded3/third_party/WebKit/Source/bindings/scripts/blink_idl_parser_test.py
,
Jun 29 2017
,
Jun 29 2017
Thank you very much for fixing so quickly! |
|||
►
Sign in to add a comment |
|||
Comment 1 by bashi@chromium.org
, Jun 28 2017Status: Assigned (was: Untriaged)