Media engagement index should clear data w/ history |
|||
Issue descriptionThe MEI should not leak private information regarding the user browsing history and behaviour. When the “history” is cleared for a website that has a MEI entry, the content settings should reflect the change by reducing the visit count relatively to the history being cleared. In other words, if X visits to example.com are cleared and the history still contains Y visits, the MEI visit count should be multiplied by (Y-X)/Y. The number of playback should also be changed in order to not change the score (ie. playback/visits should stay the same). If all the visits for a website are cleared, the MEI should be cleared. This will require to listen to URLDeleted from the HistoryServiceObserver and check with the HistoryService the current records it contains for a given origin. When the “cookies and other site data” are cleared, the MEI for a given site data should be cleared if the timeline includes the last time a playback has been recorded.
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c22d51c1a040d068c3ffba38b16554672ae2372 commit 4c22d51c1a040d068c3ffba38b16554672ae2372 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Jul 06 10:58:47 2017 Media Engagement: Clear data on history delete. Add a HistoryServiceObserver to watch for deleted URLs and then adjust the score as necessary. BUG= 737293 Change-Id: Idbc232e18ee3b83da508cba5d2a4d4dc5368d7fb Reviewed-on: https://chromium-review.googlesource.com/550058 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#484539} [modify] https://crrev.com/4c22d51c1a040d068c3ffba38b16554672ae2372/chrome/browser/media/media_engagement_score.h [modify] https://crrev.com/4c22d51c1a040d068c3ffba38b16554672ae2372/chrome/browser/media/media_engagement_service.cc [modify] https://crrev.com/4c22d51c1a040d068c3ffba38b16554672ae2372/chrome/browser/media/media_engagement_service.h [modify] https://crrev.com/4c22d51c1a040d068c3ffba38b16554672ae2372/chrome/browser/media/media_engagement_service_factory.cc [modify] https://crrev.com/4c22d51c1a040d068c3ffba38b16554672ae2372/chrome/browser/media/media_engagement_service_unittest.cc
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0868ee3d717fa40b41fdb0f427cb7da1572b166 commit c0868ee3d717fa40b41fdb0f427cb7da1572b166 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Jul 06 13:50:04 2017 Media Engagement: Clear data on site data removal. When "cookies and other site data" is cleared we should clear any Media Engagement data if the last playback time is within the time range of the removed data. BUG= 737293 Change-Id: I45baa5c6c3487a8c8979031f376e5b108c204208 Reviewed-on: https://chromium-review.googlesource.com/551255 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#484571} [modify] https://crrev.com/c0868ee3d717fa40b41fdb0f427cb7da1572b166/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc [modify] https://crrev.com/c0868ee3d717fa40b41fdb0f427cb7da1572b166/chrome/browser/media/media_engagement_score.h [modify] https://crrev.com/c0868ee3d717fa40b41fdb0f427cb7da1572b166/chrome/browser/media/media_engagement_service.cc [modify] https://crrev.com/c0868ee3d717fa40b41fdb0f427cb7da1572b166/chrome/browser/media/media_engagement_service.h [modify] https://crrev.com/c0868ee3d717fa40b41fdb0f427cb7da1572b166/chrome/browser/media/media_engagement_service_unittest.cc
,
Jul 10 2017
,
Aug 30 2017
,
Jul 27
This should also be applied when you use `DevTools > Application > Clear Storage > Clear site data` Currently, it does not.
,
Jul 27
Clear storage is removing data that can be read and written by a website (e.g. localstorage or cookies). Media engagement is created implicitly, so we deleted it with history like some other types of similar data. Why would you like to have it deleted here?
,
Dec 27
Delete comment ⚐ Hi When is this being fixed please? MEI site (link) still has data on visits for sites that I've deleted all content (second link). chrome://media-engagement/ https://myactivity.google.com/myactivity?utm_source=chrome_cbd This feels like a privacy issue.
,
Jan 2
When you go to chrome://settings/clearBrowserData, select "History" and a time range of "All time", media engagement should be cleared completely. Does this not work for you? Which version of Chrome and which OS are you using?
,
Jan 2
@dullweber@chromium.org But that would mean it's not possible to clear the data for just a single site... You have to clear it for everything, which is not always ideal... plus you have to clear all your History... should be clearable by clearing site data...
,
Jan 3
Do you need this for debugging purposes? In this case it would probably be best to file a new bug for devtools to include MediaEngagement and maybe also SiteEngagement in "Clear storage". It is currently only possible to reset MediaEngagement for a site by deleting all urls of this site from History. |
|||
►
Sign in to add a comment |
|||
Comment 1 by cfroussios@chromium.org
, Jun 29 2017