Refactoring: Move the latter part of KeyboardLayoutManager::SetChildBounds into KeyboardController |
|||||||
Issue descriptionMost of the code touchs KeyboardController. Let's extract a method into KeyboardController and call it.
,
Jun 30 2017
<triage> omrilio@, could you please triage?
,
Jun 30 2017
,
Jul 13 2017
,
Jul 13 2017
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea210048a3286f41d9363cf072abca602a44acc5 commit ea210048a3286f41d9363cf072abca602a44acc5 Author: oka@chromium.org <oka@chromium.org> Date: Wed Jul 19 14:02:10 2017 Move the latter part of SetChildBounds to KeyboardController Also refactored the code Bug: 737292 Test: try Change-Id: I854b5fbf249b7d2257dc580a638be6bcaaf576a3 Reviewed-on: https://chromium-review.googlesource.com/571340 Commit-Queue: Keigo Oka <oka@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#487848} [modify] https://crrev.com/ea210048a3286f41d9363cf072abca602a44acc5/ui/keyboard/keyboard_controller.cc [modify] https://crrev.com/ea210048a3286f41d9363cf072abca602a44acc5/ui/keyboard/keyboard_controller.h [modify] https://crrev.com/ea210048a3286f41d9363cf072abca602a44acc5/ui/keyboard/keyboard_layout_manager.cc
,
Jul 26 2017
,
Aug 10 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by oka@chromium.org
, Jun 27 2017