New issue
Advanced search Search tips

Issue 737286 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[TTS] Trim being called on null

Project Member Reported by donnd@chromium.org, Jun 27 2017

Issue description

Looks like there's a crash where we're not checking for a null selection before trimming it:

Thread 60java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.String.trim()' on a null object reference
at org.chromium.chrome.browser.contextualsearch.ContextualSearchManager$5.showContextualSearchLongpressUi	(ContextualSearchManager.java:333 )
at org.chromium.chrome.browser.contextualsearch.ContextualSearchInternalStateController.transitionTo$5166USJ75THMGSJFDLKNAR9FCDK74RRDCKNM4SJFETPMASHFCDNMST35F1Q7AOBCEDIM2SJ3D0NK6RREEHINGT3LC5M56PB1E9HMGIBEEHIN4RJ1DH9N8OBKCL1MURJKE9NMOR35E8I4IRJKCLP6SOBCADQ62T357D66USJ75THMGSJFDLKNAR9FCDK74RRDCKNM4SJFETPMASHFCDNMQS3FEDKN8RRI5TH6UT3KDTMM4OBI5T7NCPBIDHGNIK31DPIMO92JEHGN8PA3D1GMSPR5A9IM2SRFDOTIILG_0	(ContextualSearchInternalStateController.java:113 )
at org.chromium.chrome.browser.contextualsearch.ContextualSearchInternalStateController.notifyFinishedWorkOn$5166USJ75THMGSJFDLKNAR9FCDK74RRDCKNM4SJFETPMASHFCDNMST35F1Q7AOBCEDIM2SJ3D0NK6RREEHINGT3LC5M56PB1E9HMGIBEEHIN4RJ1DH9N8OBKCL1MURJKE9NMOR35E8I4IRJKCLP6SOBCADQ62T357CKLC___0	(ContextualSearchInternalStateController.java:82 )
at org.chromium.chrome.browser.contextualsearch.ContextualSearchManager.onTextSurroundingSelectionAvailable	(ContextualSearchManager.java:146 )
at org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce	(Native Method )
at org.chromium.base.SystemMessageHandler.handleMessage	(SystemMessageHandler.java:7 )
at android.os.Handler.dispatchMessage	(Handler.java:102 )
at android.os.Looper.loop	(Looper.java:148 )
at android.app.ActivityThread.main	(ActivityThread.java:5417 )
at java.lang.reflect.Method.invoke
 

Comment 1 by donnd@chromium.org, Jun 28 2017

Status: WontFix (was: Started)
We can't see how this can happen with the current code so I think this got fixed.

Sign in to add a comment