New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 737261 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Jun 2017
Cc:
█ ryanchung@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Getting "No L-G-T-M from a valid reviewer yet."

Project Member Reported by eroman@chromium.org, Jun 27 2017 
I am getting that error when trying to land this CL via the commit queue:

   https://codereview.chromium.org/2918233002/

As far as I can tell everything is in order: dougsteed@chromium.org has signed off, and he is an OWNER under src/components/cast_certificate/OWNERS.

If the messaging in the error is correct, it would mean dougsteed is not a committed, but somehow is listed as an OWNER, which seems very odd. How do I check further what is going wrong here?

Thanks!

Comment 1 by thestig@chromium.org, Jun 27 2017

Cc: ryanchung@chromium.org
(drive-by) I bet this is because dougsteed@ is not a committer. Don't add non-comitters to OWNERS files?

Comment 2 by ryanchung@chromium.org, Jun 27 2017 

Sorry, my fault.
Do OWNERS strictly have to be committers?
The alternative is to just have /chromecast OWNERS take over rubber stamping but dougsteed is still the TL for that code.

Comment 3 by thestig@chromium.org, Jun 28 2017 

Given there's no enforcement, I guess it's a strict rule. However, it is inconvenient / confusing at time. I would suggest either for the non-committer to either:
a) Remember they are not a committer and ask higher level OWNERS to stamp.
b) Just write more CLs and become a committer. :)

Comment 4 by thestig@chromium.org, Jun 28 2017 

Mean to say: it's _not_ a strict rule.

Comment 5 by eroman@chromium.org, Jun 28 2017

Status: WontFix (was: Untriaged)
Thanks for the help!

Sounds like it is working as intended then
►

Sign in to add a comment