New issue
Advanced search Search tips

Issue 737260 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"ServiceWorkerBackgroundSyncTest.Sync" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 27 2017

Issue description

"ServiceWorkerBackgroundSyncTest.Sync" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLwsSBUZsYWtlIiRTZXJ2aWNlV29ya2VyQmFja2dyb3VuZFN5bmNUZXN0LlN5bmMM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 595191 .
 
Owner: jkarlin@chromium.org
Owner: peter@chromium.org
Reassigning to Peter as I no longer work on bgsync.
Labels: -Sheriff-Chromium
Cc: peter@chromium.org
Owner: lazyboy@chromium.org
Status: Started (was: Untriaged)
I've tried running these tests 300 times in tryjobs, here:
https://chromium-review.googlesource.com/c/617642/1/chrome/browser/extensions/service_worker_apitest.cc

All of 
mac_chromium_rel_ng
win_chromium_rel_ng
linux_chromium_chromeos_rel_ng
linux_chromium_asan_rel_ng and
linux_chromium_rel_ng

Passed. No retries happened at all when I inspected the logs. At this point I think I will enable the test and see.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/311f4837fc485db20fbebd19dfc30a7f3a8c30c5

commit 311f4837fc485db20fbebd19dfc30a7f3a8c30c5
Author: Istiaque Ahmed <lazyboy@chromium.org>
Date: Thu Aug 17 00:13:32 2017

Enable ServiceWorkerBackgroundSyncTest.Sync as it no longer flakes.

Since 300 runs of this test do not flake at all and pass on first try,
enable the test.

Bug:  737260 
Change-Id: Ib768398d2f5f6a640065cd1d0de6bed11df32dce
Reviewed-on: https://chromium-review.googlesource.com/617642
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495009}
[modify] https://crrev.com/311f4837fc485db20fbebd19dfc30a7f3a8c30c5/chrome/browser/extensions/service_worker_apitest.cc

Status: Fixed (was: Started)
Marking as Fixed, reopen if it flakes and I will take a look.

Sign in to add a comment