Issue 737259 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	mthiesse@chromium.org
Closed:	Jul 2017
Cc:	bsheedy@chromium.org
Components:	Blink>WebXR Internals>XR
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	1
Type:	Bug
Proj-VR M-61 XR-Caught-By-Test
Proj-XR

Blocking:
issue 737619

WebVR presentation reports success before DON flow completes.

Project Member Reported by mthiesse@chromium.org, Jun 27 2017

Issue description

Regression from https://codereview.chromium.org/2941173002/

Now that we don't manually trigger DON flow, it's asynchronously triggered after we "enter VR", which leads to reporting DON flow success too early.

This probably causes a whole host of issues, but at the very least it causes tests to erroneously pass.

Comment 1 by bsheedy@chromium.org, Jun 28 2017

Blocking: 737619

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcc6da1cac65953c78288211444ce8e83c188999

commit dcc6da1cac65953c78288211444ce8e83c188999
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Fri Jun 30 21:18:44 2017

VR: Delay setting present result until DON flow completes.

This CL does two main things:
1. It delays telling the webVR page the presentation result until
the DON flow is completed.
2. It keeps Chrome in VR when we're going through the DON flow for
both sanity and smoothness reasons (we now resume ~instantly after
the DON flow).

This CL inadvertently exposed a focus issue around presentation,
which is fixed by making sure the VrDisplay isn't blurred due to
focus while presenting. It also drive-by fixes some possible races
in starting/ending presentation, making sure bindings are closed
appropriately.

Bug:  737259 ,  737656 
Change-Id: I97892617a75a597effd70dbadbf53547a2578825
Reviewed-on: https://chromium-review.googlesource.com/553558
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483815}
[modify] https://crrev.com/dcc6da1cac65953c78288211444ce8e83c188999/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/dcc6da1cac65953c78288211444ce8e83c188999/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/dcc6da1cac65953c78288211444ce8e83c188999/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/dcc6da1cac65953c78288211444ce8e83c188999/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/dcc6da1cac65953c78288211444ce8e83c188999/chrome/test/data/android/webvr_instrumentation/html/test_presentation_locks_focus.html
[modify] https://crrev.com/dcc6da1cac65953c78288211444ce8e83c188999/third_party/WebKit/Source/modules/vr/VRDisplay.cpp