New issue
Advanced search Search tips

Issue 737248 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR



Sign in to add a comment

VR: requestPresent with Daydream View paired and 'skip VR entry screens on' hits assert

Project Member Reported by mthiesse@chromium.org, Jun 27 2017

Issue description

VR: requestPresent with Daydream View paired and 'skip VR entry screens on' hits the assert that we're not in VR when receiving the broadcast response, because the pause that VR DON flow normally causes doesn't happen.

This is perfectly expected, so we should probably just remove the assert.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9284f4661a5ef7cdde67c59dcfc52653bad46489

commit 9284f4661a5ef7cdde67c59dcfc52653bad46489
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Thu Jun 29 03:21:26 2017

VR: Remove assert that we're not in VR when receiving the VR broadcast.

requestPresent with Daydream View paired and 'skip VR entry screens on' hits the
assert that we're not in VR when receiving the broadcast response, because the
pause that VR DON flow normally causes doesn't happen.

Bug:  737248 
Change-Id: I4b095ae42129ffc5243aeb3e257367175cce65d2
Reviewed-on: https://chromium-review.googlesource.com/550377
Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483279}
[modify] https://crrev.com/9284f4661a5ef7cdde67c59dcfc52653bad46489/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Status: Fixed (was: Assigned)
Components: -UI>Browser>VR Internals>VR
Labels: Proj-VR-Daydream
Components: Internals>XR

Sign in to add a comment