New issue
Advanced search Search tips

Issue 737240 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Run desktopui_MashLogin against tip-of-trunk Chrome on an informational builder

Project Member Reported by jamescook@chromium.org, Jun 27 2017

Issue description

We're not going to ship go/mustash (chrome --mash) for many months, but we need hardware test coverage to exercise the new GPU and display management initialization code.

Ideally this would run continuously against ToT chrome, but not block Chrome uprev for now. Once the code is stable we can move it to bvt-cq or a similar suite.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b3360d2bc3f89fc5a7acc1ac0e56aa88fcca4bb2

commit b3360d2bc3f89fc5a7acc1ac0e56aa88fcca4bb2
Author: James Cook <jamescook@chromium.org>
Date: Thu Jun 29 10:11:36 2017

autotest: Add chrome-informational test suite

Move desktopui_MusLogin and desktopui_MashLogin to the new suite.
These tests need to run on hardware, but are for features in Chrome
that are still under development behind flags. We don't want to
block Chrome PFQ uprev if they fail, just inform the gardener.

This gives us an alternative to bvt-perbuild that we can run
continuously against ToT chrome to provide narrower chrome
revision ranges for regressions.

Remove hacky board-specific control files for these tests. They
were an attempt to put the tests in bvt-cq for just a couple of
boards, but if we introduce a flaky regression in these features
we don't want to block the CQ.

BUG= chromium:737240 
TEST=presubmits
Change-Id: I97af6d24793c2fed529b3cc799960c07506228ac
Reviewed-on: https://chromium-review.googlesource.com/550863
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Tested-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/b3360d2bc3f89fc5a7acc1ac0e56aa88fcca4bb2/site_utils/attribute_whitelist.txt
[modify] https://crrev.com/b3360d2bc3f89fc5a7acc1ac0e56aa88fcca4bb2/client/site_tests/desktopui_MashLogin/control
[delete] https://crrev.com/8cd88d5da11a533460ec49ed1caa6afb614bfd63/client/site_tests/desktopui_MashLogin/control.peach_pit
[add] https://crrev.com/b3360d2bc3f89fc5a7acc1ac0e56aa88fcca4bb2/test_suites/control.chrome-informational
[delete] https://crrev.com/8cd88d5da11a533460ec49ed1caa6afb614bfd63/client/site_tests/desktopui_MashLogin/README
[delete] https://crrev.com/8cd88d5da11a533460ec49ed1caa6afb614bfd63/client/site_tests/desktopui_MashLogin/control.tricky
[modify] https://crrev.com/b3360d2bc3f89fc5a7acc1ac0e56aa88fcca4bb2/client/site_tests/desktopui_MusLogin/control
[delete] https://crrev.com/8cd88d5da11a533460ec49ed1caa6afb614bfd63/client/site_tests/desktopui_MashLogin/control.link

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e4f98a342477f14b6a30dabf18791aa9d0016dec

commit e4f98a342477f14b6a30dabf18791aa9d0016dec
Author: James Cook <jamescook@chromium.org>
Date: Thu Jun 29 15:47:59 2017

Revert "autotest: Add chrome-informational test suite"

This reverts commit b3360d2bc3f89fc5a7acc1ac0e56aa88fcca4bb2.

Reason for revert: I didn't intend to land this quite yet.

Original change's description:
> autotest: Add chrome-informational test suite
> 
> Move desktopui_MusLogin and desktopui_MashLogin to the new suite.
> These tests need to run on hardware, but are for features in Chrome
> that are still under development behind flags. We don't want to
> block Chrome PFQ uprev if they fail, just inform the gardener.
> 
> This gives us an alternative to bvt-perbuild that we can run
> continuously against ToT chrome to provide narrower chrome
> revision ranges for regressions.
> 
> Remove hacky board-specific control files for these tests. They
> were an attempt to put the tests in bvt-cq for just a couple of
> boards, but if we introduce a flaky regression in these features
> we don't want to block the CQ.
> 
> BUG= chromium:737240 
> TEST=presubmits
> Change-Id: I97af6d24793c2fed529b3cc799960c07506228ac
> Reviewed-on: https://chromium-review.googlesource.com/550863
> Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
> Tested-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

Bug:  chromium:737240 
Change-Id: I1882b630f463a71aab7cfb08395f177e3ef316db
Reviewed-on: https://chromium-review.googlesource.com/555591
Tested-by: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>

[modify] https://crrev.com/e4f98a342477f14b6a30dabf18791aa9d0016dec/site_utils/attribute_whitelist.txt
[modify] https://crrev.com/e4f98a342477f14b6a30dabf18791aa9d0016dec/client/site_tests/desktopui_MashLogin/control
[add] https://crrev.com/e4f98a342477f14b6a30dabf18791aa9d0016dec/client/site_tests/desktopui_MashLogin/control.peach_pit
[delete] https://crrev.com/66aa254e6ce449cfd9b49b552c606f95ad53d612/test_suites/control.chrome-informational
[add] https://crrev.com/e4f98a342477f14b6a30dabf18791aa9d0016dec/client/site_tests/desktopui_MashLogin/README
[add] https://crrev.com/e4f98a342477f14b6a30dabf18791aa9d0016dec/client/site_tests/desktopui_MashLogin/control.tricky
[modify] https://crrev.com/e4f98a342477f14b6a30dabf18791aa9d0016dec/client/site_tests/desktopui_MusLogin/control
[add] https://crrev.com/e4f98a342477f14b6a30dabf18791aa9d0016dec/client/site_tests/desktopui_MashLogin/control.link

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/25e6a459e646cfb08182e674aec88e3ae2c8c12d

commit 25e6a459e646cfb08182e674aec88e3ae2c8c12d
Author: James Cook <jamescook@chromium.org>
Date: Wed Jul 12 00:48:02 2017

Reland "autotest: Add chrome-informational test suite"

This is a reland of b3360d2bc3f89fc5a7acc1ac0e56aa88fcca4bb2
Original change's description:
> autotest: Add chrome-informational test suite
>
> Move desktopui_MusLogin and desktopui_MashLogin to the new suite.
> These tests need to run on hardware, but are for features in Chrome
> that are still under development behind flags. We don't want to
> block Chrome PFQ uprev if they fail, just inform the gardener.
>
> This gives us an alternative to bvt-perbuild that we can run
> continuously against ToT chrome to provide narrower chrome
> revision ranges for regressions.
>
> Remove hacky board-specific control files for these tests. They
> were an attempt to put the tests in bvt-cq for just a couple of
> boards, but if we introduce a flaky regression in these features
> we don't want to block the CQ.
>
> BUG= chromium:737240 
> TEST=presubmits
> Change-Id: I97af6d24793c2fed529b3cc799960c07506228ac
> Reviewed-on: https://chromium-review.googlesource.com/550863
> Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
> Tested-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

Bug:  chromium:737240 
Change-Id: I4488c58056ae18aeb5fc555ef40ce03508a2dbfe
Reviewed-on: https://chromium-review.googlesource.com/556885
Commit-Ready: James Cook <jamescook@chromium.org>
Tested-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/25e6a459e646cfb08182e674aec88e3ae2c8c12d/site_utils/attribute_whitelist.txt
[modify] https://crrev.com/25e6a459e646cfb08182e674aec88e3ae2c8c12d/client/site_tests/desktopui_MashLogin/control
[delete] https://crrev.com/d0d07388c5512c362786cef316cf02ffba528e47/client/site_tests/desktopui_MashLogin/control.peach_pit
[add] https://crrev.com/25e6a459e646cfb08182e674aec88e3ae2c8c12d/test_suites/control.chrome-informational
[delete] https://crrev.com/d0d07388c5512c362786cef316cf02ffba528e47/client/site_tests/desktopui_MashLogin/README
[delete] https://crrev.com/d0d07388c5512c362786cef316cf02ffba528e47/client/site_tests/desktopui_MashLogin/control.tricky
[modify] https://crrev.com/25e6a459e646cfb08182e674aec88e3ae2c8c12d/client/site_tests/desktopui_MusLogin/control
[delete] https://crrev.com/d0d07388c5512c362786cef316cf02ffba528e47/client/site_tests/desktopui_MashLogin/control.link

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/8faa830a8225872b0a19cac96a908b86fb3b43f0

commit 8faa830a8225872b0a19cac96a908b86fb3b43f0
Author: James Cook <jamescook@chromium.org>
Date: Fri Jul 14 02:46:20 2017

cbuildbot: Add chrome-informational suite

Tests like desktopui_MashLogin and desktopui_MusLogin need to run
on hardware to test Chrome GPU initialization code, but are for
features that are still under development behind flags. We don't
want to block Chrome PFQ uprev if they fail, just inform the
Chrome gardener.

This CL will make those hardware tests appear on this waterfall:
https://uberchromegw.corp.google.com/i/chromeos.chrome/waterfall

They will run continuously against tip-of-trunk Chrome, not
against the daily Chrome branch.

BUG= chromium:737240 
TEST=cbuildbot/chromeos_config_unittest
CQ-DEPEND=CL:556885

Change-Id: I5c90f93244c02b7bff1215092472da547a943e9b
Reviewed-on: https://chromium-review.googlesource.com/551022
Commit-Ready: James Cook <jamescook@chromium.org>
Tested-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/8faa830a8225872b0a19cac96a908b86fb3b43f0/cbuildbot/config_dump.json
[modify] https://crrev.com/8faa830a8225872b0a19cac96a908b86fb3b43f0/lib/constants.py
[modify] https://crrev.com/8faa830a8225872b0a19cac96a908b86fb3b43f0/cbuildbot/chromeos_config.py

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment