New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737231 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
On parental leave until 3/15/19
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature

Blocked on:
issue 710633
issue 742396



Sign in to add a comment

Enable Brotli in Cronet for iOS

Project Member Reported by mef@chromium.org, Jun 27 2017

Issue description

This bug is filed to track Brotli in Cronet for iOS.

(1) New version of Cronet will include Brotli library.
(2) Cronet will expose an API to enable/disable Brotli on CronetEngine. 

 

Comment 1 by mef@chromium.org, Jun 27 2017

Blockedon: 710633
Cc: lilyhoughton@chromium.org kapishnikov@chromium.org mef@chromium.org
Components: Internals>Network>Library

Comment 2 by sczs@chromium.org, Jun 28 2017

Cc: -mef@chromium.org
Owner: mef@chromium.org
Status: Assigned (was: Untriaged)
Assigning to mef@ as part of triaging, please re-assign if necessary. 
Owner: lassey@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/250b62478e3d19ec45c5a58b7f9b8c5aa451d961

commit 250b62478e3d19ec45c5a58b7f9b8c5aa451d961
Author: Brad Lassey <lassey@chromium.org>
Date: Mon Jul 10 14:19:57 2017

Add Brotli support to iOS Cronet

This adds a getter and setter to enable and disable brotli. The test
tests that brotli is advertised (or not) and that encoded data can be
decoded correctly.

Bug =  737231 

Bug:  737231 
Change-Id: I63e58f97725764b74f51a86edc2ed0eefafe7476
Reviewed-on: https://chromium-review.googlesource.com/563857
Commit-Queue: Brad Lassey <lassey@chromium.org>
Reviewed-by: smut <smut@google.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485262}
[modify] https://crrev.com/250b62478e3d19ec45c5a58b7f9b8c5aa451d961/components/cronet/ios/Cronet.h
[modify] https://crrev.com/250b62478e3d19ec45c5a58b7f9b8c5aa451d961/components/cronet/ios/Cronet.mm
[modify] https://crrev.com/250b62478e3d19ec45c5a58b7f9b8c5aa451d961/components/cronet/ios/cronet_environment.h
[modify] https://crrev.com/250b62478e3d19ec45c5a58b7f9b8c5aa451d961/components/cronet/ios/cronet_environment.mm
[modify] https://crrev.com/250b62478e3d19ec45c5a58b7f9b8c5aa451d961/components/cronet/ios/test/cronet_http_test.mm
[modify] https://crrev.com/250b62478e3d19ec45c5a58b7f9b8c5aa451d961/components/cronet/ios/test/test_server.cc
[modify] https://crrev.com/250b62478e3d19ec45c5a58b7f9b8c5aa451d961/components/cronet/ios/test/test_server.h
[modify] https://crrev.com/250b62478e3d19ec45c5a58b7f9b8c5aa451d961/components/cronet/tools/cr_cronet.py
[modify] https://crrev.com/250b62478e3d19ec45c5a58b7f9b8c5aa451d961/ios/build/bots/chromium.mac/ios-simulator-cronet.json

Comment 5 by lassey@chromium.org, Jul 10 2017

Status: Fixed (was: Started)

Comment 6 by mef@chromium.org, Jul 13 2017

Blockedon: 742396
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ea248d71fd453ca7f09a1c488e2389f4460b899

commit 6ea248d71fd453ca7f09a1c488e2389f4460b899
Author: Brad Lassey <lassey@chromium.org>
Date: Thu Jul 13 17:47:04 2017

Consistently enable brotli in Cronet iOS builds

Bug:  737231 
Change-Id: Id6f45920f7dae7e185da6b663f3bc0cfb8073cc3
Reviewed-on: https://chromium-review.googlesource.com/568856
Commit-Queue: Brad Lassey <lassey@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486434}
[modify] https://crrev.com/6ea248d71fd453ca7f09a1c488e2389f4460b899/components/cronet/tools/package_ios.py
[modify] https://crrev.com/6ea248d71fd453ca7f09a1c488e2389f4460b899/ios/build/bots/chromium.fyi/ios-simulator-cronet.json

Sign in to add a comment