New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737204 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

betty-pre-cq consistently failing VMTest

Project Member Reported by akes...@chromium.org, Jun 27 2017

Issue description

Cc: ihf@chromium.org
Betty was added in https://chromium-review.googlesource.com/544757 (Issue 710629)
Cc: norvez@chromium.org bhthompson@chromium.org
Consider reverting #2 (would require rebasing all affected CLs).

Note that will leave us with no vmtest coverage.

Also, ARC++ constables should be looped in here.
Cc: levarum@chromium.org nya@chromium.org
> Note that will leave us with no vmtest coverage.

There's a unit test that will fail if that's so.

However, looking at the previous code, there was this builder
configured:
   'cyan-pre-cq',                    # braswell     kernel 3.18       vmtest

The comment says (and I believe) that this builder runs VM tests.

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/ac3a48c0bca5bfe321f414f5b8c64190653f4483

commit ac3a48c0bca5bfe321f414f5b8c64190653f4483
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Tue Jun 27 19:45:35 2017

Revert "pre-cq: use betty for VMTest, add more builders."

This reverts commit 7c73fe82f9d624c34c2ec5f13516da6edde992e3.

The betty-pre-cq doesn't pass.

BUG= chromium:737204 
TEST=run unit tests locally

Change-Id: I08bf5abf6f9724f8c26890bc6c0bf3a562d54ee3
Reviewed-on: https://chromium-review.googlesource.com/550322
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>

[modify] https://crrev.com/ac3a48c0bca5bfe321f414f5b8c64190653f4483/lib/constants.py

The revert should resolve the problem - mostly.

The tree is open, but some developers will continue to see
betty-pre-cq failures until the they rebase or otherwise
change their CL.

This PSA has more details:
    https://groups.google.com/a/chromium.org/forum/?hl=en#!topic/chromium-os-dev/zb0DlqwOOPw

Labels: -Pri-0 Pri-1
Downgrading, on the theory that the change will work as advertised.

While reverting this is ok to stop the bleeding...

If the failure is a legitimate break, and not a flake, it seems like turning this off is just putting the real problem under the rug, we should try to figure out why betty was failing.

I suspect we do ultimately care if betty is not working.

Adding betty into the CQ proper as experimental and promoting it should help to prevent such failure.
> If the failure is a legitimate break, and not a flake, it
> seems like turning this off is just putting the real problem
> under the rug, we should try to figure out why betty was failing.

This bug can stay open to figure out why betty-pre-cq is failing.

Meanwhile, looking at the status of things, "betty" never should
have been added to the pre-cq.  The canary is red, failing VMTest,
and has been for most of a week.  It was red when we made the builder
a blocker for all CL advancement yesterday.  Until the builder can be
consistently green, it can't be added to the pre-CQ.

Comment 12 by ihf@chromium.org, Jun 28 2017

Replaced is not the right word, a few CTS tests were added to smoke suite. They ran fine on cyan VMTest but there was a caroline and betty VMTest regression that came in via Android PFQ (b/62935227). The reason you don't see more tests in the newer smoke suite is that CTS ran first and then hung/ran into a timeout. 

The correct thing here would have been to remove CtsAccountManagerTestCases from smoke and re-enable betty pre-cq with the shorter smoke suite.

That said it is very regrettable that cyan runs many VMTests fine, while caroline VMTest and betty VMTest do seem to cause more problems. The betty failure needs to be addressed.

Comment 13 by ihf@chromium.org, Jun 28 2017

Owner: ihf@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/autotest-cheets/+/dcdff7562c5237cab758735da571ac8d304d3704

commit dcdff7562c5237cab758735da571ac8d304d3704
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Wed Jun 28 01:13:32 2017

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/81a4cbbf4a45164b53664f049f764f17d04da12a

commit 81a4cbbf4a45164b53664f049f764f17d04da12a
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Wed Jun 28 10:09:50 2017

Reland "pre-cq: use betty for VMTest, add more builders."

This reverts commit ac3a48c0bca5bfe321f414f5b8c64190653f4483.

The failing test CtsAccountManagerTestCases has been removed from the smoke suite. Carry on with pre-cq betty.
https://chrome-internal-review.googlesource.com/#/c/402730/

BUG=b:62935227, chromium:710629,  chromium:737204 
TEST=Will test itself.

Change-Id: Iee32121e4190dc3c06760ddaaffe145fc578d3c1
Reviewed-on: https://chromium-review.googlesource.com/551111
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/81a4cbbf4a45164b53664f049f764f17d04da12a/lib/constants.py

Comment 16 by sjg@google.com, Jun 28 2017

Is this fixed now?
Status: Verified (was: Started)
I found a passing betty-pre-cq, so yes I think: https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/pre_cq/builds/41513
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 30 2017

Labels: merge-merged-release-R60-9592.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/autotest-cheets/+/d2efdbb239e3281a8e022c2bef36d26d45a46f1c

commit d2efdbb239e3281a8e022c2bef36d26d45a46f1c
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Fri Jun 30 19:06:28 2017

Sign in to add a comment