betty-pre-cq consistently failing VMTest |
|||||||
Issue descriptionRecent specimen: https://luci-milo.appspot.com/buildbot/chromiumos.tryserver/pre_cq/41164 P0 tree closer.
,
Jun 27 2017
Betty was added in https://chromium-review.googlesource.com/544757 (Issue 710629)
,
Jun 27 2017
Consider reverting #2 (would require rebasing all affected CLs). Note that will leave us with no vmtest coverage. Also, ARC++ constables should be looped in here.
,
Jun 27 2017
,
Jun 27 2017
> Note that will leave us with no vmtest coverage. There's a unit test that will fail if that's so. However, looking at the previous code, there was this builder configured: 'cyan-pre-cq', # braswell kernel 3.18 vmtest The comment says (and I believe) that this builder runs VM tests.
,
Jun 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ac3a48c0bca5bfe321f414f5b8c64190653f4483 commit ac3a48c0bca5bfe321f414f5b8c64190653f4483 Author: Richard Barnette <jrbarnette@chromium.org> Date: Tue Jun 27 19:45:35 2017 Revert "pre-cq: use betty for VMTest, add more builders." This reverts commit 7c73fe82f9d624c34c2ec5f13516da6edde992e3. The betty-pre-cq doesn't pass. BUG= chromium:737204 TEST=run unit tests locally Change-Id: I08bf5abf6f9724f8c26890bc6c0bf3a562d54ee3 Reviewed-on: https://chromium-review.googlesource.com/550322 Reviewed-by: Aviv Keshet <akeshet@chromium.org> Tested-by: Richard Barnette <jrbarnette@chromium.org> [modify] https://crrev.com/ac3a48c0bca5bfe321f414f5b8c64190653f4483/lib/constants.py
,
Jun 27 2017
The revert should resolve the problem - mostly.
The tree is open, but some developers will continue to see
betty-pre-cq failures until the they rebase or otherwise
change their CL.
This PSA has more details:
https://groups.google.com/a/chromium.org/forum/?hl=en#!topic/chromium-os-dev/zb0DlqwOOPw
,
Jun 27 2017
Downgrading, on the theory that the change will work as advertised.
,
Jun 27 2017
While reverting this is ok to stop the bleeding... If the failure is a legitimate break, and not a flake, it seems like turning this off is just putting the real problem under the rug, we should try to figure out why betty was failing. I suspect we do ultimately care if betty is not working. Adding betty into the CQ proper as experimental and promoting it should help to prevent such failure.
,
Jun 27 2017
> If the failure is a legitimate break, and not a flake, it > seems like turning this off is just putting the real problem > under the rug, we should try to figure out why betty was failing. This bug can stay open to figure out why betty-pre-cq is failing. Meanwhile, looking at the status of things, "betty" never should have been added to the pre-cq. The canary is red, failing VMTest, and has been for most of a week. It was red when we made the builder a blocker for all CL advancement yesterday. Until the builder can be consistently green, it can't be added to the pre-CQ.
,
Jun 27 2017
Regarding the canary failures, it looks like the content of the smoke suite changed last week if you compare: https://luci-milo.appspot.com/buildbot/chromeos/betty-release/275 https://pantheon.corp.google.com/storage/browser/chromeos-image-archive/betty-release/R61-9675.0.0/vm_test_results_1/smoke_suite/test_harness/all/SimpleTestVerify/1_autotest_tests/ https://luci-milo.appspot.com/buildbot/chromeos/betty-release/276 https://pantheon.corp.google.com/storage/browser/chromeos-image-archive/betty-release/R61-9676.0.0/vm_test_results_1/smoke_suite/test_harness/all/SimpleTestVerify/1_autotest_tests/ It looks like smoke tests have been replaced with a subset of CTS?
,
Jun 28 2017
Replaced is not the right word, a few CTS tests were added to smoke suite. They ran fine on cyan VMTest but there was a caroline and betty VMTest regression that came in via Android PFQ (b/62935227). The reason you don't see more tests in the newer smoke suite is that CTS ran first and then hung/ran into a timeout. The correct thing here would have been to remove CtsAccountManagerTestCases from smoke and re-enable betty pre-cq with the shorter smoke suite. That said it is very regrettable that cyan runs many VMTests fine, while caroline VMTest and betty VMTest do seem to cause more problems. The betty failure needs to be addressed.
,
Jun 28 2017
,
Jun 28 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/autotest-cheets/+/dcdff7562c5237cab758735da571ac8d304d3704 commit dcdff7562c5237cab758735da571ac8d304d3704 Author: Ilja H. Friedel <ihf@chromium.org> Date: Wed Jun 28 01:13:32 2017
,
Jun 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/81a4cbbf4a45164b53664f049f764f17d04da12a commit 81a4cbbf4a45164b53664f049f764f17d04da12a Author: Ilja H. Friedel <ihf@chromium.org> Date: Wed Jun 28 10:09:50 2017 Reland "pre-cq: use betty for VMTest, add more builders." This reverts commit ac3a48c0bca5bfe321f414f5b8c64190653f4483. The failing test CtsAccountManagerTestCases has been removed from the smoke suite. Carry on with pre-cq betty. https://chrome-internal-review.googlesource.com/#/c/402730/ BUG=b:62935227, chromium:710629, chromium:737204 TEST=Will test itself. Change-Id: Iee32121e4190dc3c06760ddaaffe145fc578d3c1 Reviewed-on: https://chromium-review.googlesource.com/551111 Commit-Ready: Ilja H. Friedel <ihf@chromium.org> Tested-by: Ilja H. Friedel <ihf@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/81a4cbbf4a45164b53664f049f764f17d04da12a/lib/constants.py
,
Jun 28 2017
Is this fixed now?
,
Jun 28 2017
I found a passing betty-pre-cq, so yes I think: https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/pre_cq/builds/41513
,
Jun 30 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/autotest-cheets/+/d2efdbb239e3281a8e022c2bef36d26d45a46f1c commit d2efdbb239e3281a8e022c2bef36d26d45a46f1c Author: Ilja H. Friedel <ihf@chromium.org> Date: Fri Jun 30 19:06:28 2017 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by akes...@chromium.org
, Jun 27 2017