This bug will be linked from the chrome status entry page.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da9f22e7d4c44c80c53b6aac8ad3271c4272585d

commit da9f22e7d4c44c80c53b6aac8ad3271c4272585d
Author: Charles Harrison <csharrison@chromium.org>
Date: Thu Aug 17 16:36:59 2017

[subresource_filter] Refactor: Store full SB metadata in the throttle

This CL changes no behavior, but is a necessary refactor for when we
add metadata entries to the safe browsing entries.

Bug:  737201 
Change-Id: Ie1bdb698cd206ee867edfb2cf11af17e7c365ea8
Reviewed-on: https://chromium-review.googlesource.com/617340
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495194}
[modify] https://crrev.com/da9f22e7d4c44c80c53b6aac8ad3271c4272585d/components/subresource_filter/content/browser/content_activation_list_utils.cc
[modify] https://crrev.com/da9f22e7d4c44c80c53b6aac8ad3271c4272585d/components/subresource_filter/content/browser/content_activation_list_utils.h
[modify] https://crrev.com/da9f22e7d4c44c80c53b6aac8ad3271c4272585d/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc
[modify] https://crrev.com/da9f22e7d4c44c80c53b6aac8ad3271c4272585d/components/subresource_filter/content/browser/subresource_filter_safe_browsing_client.cc
[modify] https://crrev.com/da9f22e7d4c44c80c53b6aac8ad3271c4272585d/components/subresource_filter/content/browser/subresource_filter_safe_browsing_client.h
[modify] https://crrev.com/da9f22e7d4c44c80c53b6aac8ad3271c4272585d/components/subresource_filter/content/browser/subresource_filter_safe_browsing_client_request.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3847adb4ab31d7d8b3abd482dc9a71784411b63c

commit 3847adb4ab31d7d8b3abd482dc9a71784411b63c
Author: Charles Harrison <csharrison@chromium.org>
Date: Tue Aug 29 02:24:49 2017

[subresource_filter] Add Better Ads / Abusive ads Activation lists

This patch hooks up the safe browsing metadata added in [1] to the
subresource_filter component to form 3 new ActivationLists.

This CL does not address the "experimental" metadata.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/616120

Bug:  756089 , 737201 
Change-Id: I4ecb5af9e1660cb73290641e1d857cb0e747bef7
Reviewed-on: https://chromium-review.googlesource.com/624314
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497989}
[modify] https://crrev.com/3847adb4ab31d7d8b3abd482dc9a71784411b63c/components/subresource_filter/content/browser/content_activation_list_utils.cc
[modify] https://crrev.com/3847adb4ab31d7d8b3abd482dc9a71784411b63c/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc
[modify] https://crrev.com/3847adb4ab31d7d8b3abd482dc9a71784411b63c/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc
[modify] https://crrev.com/3847adb4ab31d7d8b3abd482dc9a71784411b63c/components/subresource_filter/core/browser/subresource_filter_features.cc
[modify] https://crrev.com/3847adb4ab31d7d8b3abd482dc9a71784411b63c/components/subresource_filter/core/browser/subresource_filter_features.h
[modify] https://crrev.com/3847adb4ab31d7d8b3abd482dc9a71784411b63c/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc
[modify] https://crrev.com/3847adb4ab31d7d8b3abd482dc9a71784411b63c/components/subresource_filter/core/common/activation_list.cc
[modify] https://crrev.com/3847adb4ab31d7d8b3abd482dc9a71784411b63c/components/subresource_filter/core/common/activation_list.h
[modify] https://crrev.com/3847adb4ab31d7d8b3abd482dc9a71784411b63c/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f20c6a019aa6609f08569ebd27a74fc39a7f7ce1

commit f20c6a019aa6609f08569ebd27a74fc39a7f7ce1
Author: Charles Harrison <csharrison@chromium.org>
Date: Wed Aug 30 15:10:55 2017

[subresource_filter] Add experimental finch param

This CL adds a finch param to subresource_filter. This bool aligns with
the new safe browsing metadata experimental bit.

If the safe browsing check shows that the list entry has the experimental
bit set to true, then we abort activation matching unless this finch
param is set.

Bug:  737201 , 756089 
Change-Id: I6df7c0d3f48ca261445d40e77b3ec7387ef24b84
Reviewed-on: https://chromium-review.googlesource.com/629256
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498464}
[modify] https://crrev.com/f20c6a019aa6609f08569ebd27a74fc39a7f7ce1/components/subresource_filter/content/browser/fake_safe_browsing_database_manager.cc
[modify] https://crrev.com/f20c6a019aa6609f08569ebd27a74fc39a7f7ce1/components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h
[modify] https://crrev.com/f20c6a019aa6609f08569ebd27a74fc39a7f7ce1/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc
[modify] https://crrev.com/f20c6a019aa6609f08569ebd27a74fc39a7f7ce1/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.h
[modify] https://crrev.com/f20c6a019aa6609f08569ebd27a74fc39a7f7ce1/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc
[modify] https://crrev.com/f20c6a019aa6609f08569ebd27a74fc39a7f7ce1/components/subresource_filter/core/browser/subresource_filter_features.cc
[modify] https://crrev.com/f20c6a019aa6609f08569ebd27a74fc39a7f7ce1/components/subresource_filter/core/browser/subresource_filter_features.h

Tested the issue using latest Canary #63.0.3227.0 on Mac 10.12.6, Win 10 and Linux Ubuntu 14.04

Feature: Abusive Ad's

Below are the scenario's tested:
===============================

TC_01: Test to verify abusive ad's which try to open new window or new tabs are blocked.
Observations: 
1. Observed "Pop up Blocked omnibox icon(To the right end of omnibox)"
2. Observed Clicking on the "Pop up Blocked Omnibox icon" should bring up "The following pop-ups were blocked on this page <Page info> and options {Always allow pop-ups from <Page name>" and "Continue blocking pop-ups" with options "[Done] and [Manage]"

Tc_02: Test to verify "Always allow pop-ups from <Test page>" should always allow the pop-ups from the slected webpages.
Observations: 
1. Clicking on "Window.open() popup and spoof shift click popup", observed the "Pop up Blocked omnibox icon(To the right end of omnibox)"
2. Observed Clicking on the "Pop up Blocked Omnibox icon" should bring up "The following pop-ups were blocked on this page <Page info> and options {Always allow pop-ups from <Page name>" and "Continue blocking pop-ups(Selected by default)" with options "[Done] and [Manage]"
3. Observed the entry of the page in step2 is added to "Chrome://settings/popups
4. Observed pop-ups are allowed on the page next time when user clicks on "Window.open() popup and spoof shift click popup"

TC_03: Test to verify "Always allow pop-ups from <Test page>" should always allow the pop-ups from the slected webpages.
Observations: 
1. observed the "Pop up Blocked omnibox icon(To the right end of omnibox)"
2. Observed on Clicking on the "Pop up Blocked Omnibox icon" should bring up "The following pop-ups were blocked on this page <Page info> and options {Always allow pop-ups from <Page name>" and "Continue blocking pop-ups(Selected by default)" with options "[Done] and [Manage]"
3. Observed the entry of the page in step2 is added to "Chrome://settings/popups
4. Observed pop-ups are allowed on the page next time when user clicks on "Window.open() popup and spoof shift click popup"

TC_04: Test to verify that the options selected from page info dialog are honored i.e., "Use global default(Block)" or "Always allow on this site" or Always block on this site"
Observations:
1. Observed that by default "Use global default(Block)" is selected 
2. Observed "Always allow on this site" is selected 
3. Observed  "Alwyas block on this site" is selected 

TC_05: "Test to verify that popup blocking is only on the testpage but not on the all sites.
Observations: Observed a new windows is opened when clicked on popup 

@csharrison: Could you please find the above observations and let us know the update.

Thanks!!

Tested the issue using latest Canary #63.0.3227.0 on Mac 10.12.6, Windows 7 and Ubuntu 14.04.

Feature: Chromenolia

Executed all the test cases given in the below link and can observe no issues. The feature is working as intended.
https://docs.google.com/spreadsheets/d/1c6rDGPGANZde7Ivh81Htlepk5vI2guz86thzGdL7qwg/edit#gid=0

Please find the attached screen cast for reference and update if the feature is working as expected.

Thanks..

Deleted: 737201.webm 7.2 MB

	737201.webm 7.2 MB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25bdcd914adf4558a5acb4b265ba15496673d575

commit 25bdcd914adf4558a5acb4b265ba15496673d575
Author: Charles Harrison <csharrison@chromium.org>
Date: Tue Oct 03 12:51:34 2017

[subresource_filter] Presets for Better Ads and Abusive Ads

Bug:  756089 ,  737201 
Change-Id: If5a0805dbf5b48f4be69642fd6db685d2943e5b9
Reviewed-on: https://chromium-review.googlesource.com/646602
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506012}
[modify] https://crrev.com/25bdcd914adf4558a5acb4b265ba15496673d575/components/subresource_filter/core/browser/subresource_filter_features.cc
[modify] https://crrev.com/25bdcd914adf4558a5acb4b265ba15496673d575/components/subresource_filter/core/browser/subresource_filter_features.h
[modify] https://crrev.com/25bdcd914adf4558a5acb4b265ba15496673d575/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9f882c736eb48d8cefc4e42566af4ddbb7b3b6d

commit a9f882c736eb48d8cefc4e42566af4ddbb7b3b6d
Author: Charles Harrison <csharrison@chromium.org>
Date: Mon Oct 30 19:07:44 2017

[subresource_filter] Add a full hash request intercepting browsertest

This patch does a few things:
1. Beef up the TestSafeBrowsingDatabaseHelper, so callers can optionally,
   pass in a custom TestV4GetHashProtocolManagerFactory. If this is null,
   then the helper will not mock the v4 hash protocol manager. This
   causes real API requests to go out to the network.

2. Make TestV4Store::MarkPrefixAsBad support multiple prefixes per
   prefix size.

3. Minor cleanups of names and std::make_unique

4. Add a new browser test suite for subresource_filter which uses
   the v4 embedded_test_server request handler, combined with the new
   TestSafeBrowsingDatabaseHelper, to mock out v4 API responses for
   the subresource filter list. This tests enforcement and warning
   variants.

Bug:  775530 , 737201 
Change-Id: Id26b676194fd33c28737bcb693e47ca75145f82f
Reviewed-on: https://chromium-review.googlesource.com/730405
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512567}
[modify] https://crrev.com/a9f882c736eb48d8cefc4e42566af4ddbb7b3b6d/chrome/browser/safe_browsing/test_safe_browsing_database_helper.cc
[modify] https://crrev.com/a9f882c736eb48d8cefc4e42566af4ddbb7b3b6d/chrome/browser/safe_browsing/test_safe_browsing_database_helper.h
[modify] https://crrev.com/a9f882c736eb48d8cefc4e42566af4ddbb7b3b6d/chrome/browser/safe_browsing/v4_embedded_test_server_browsertest.cc
[modify] https://crrev.com/a9f882c736eb48d8cefc4e42566af4ddbb7b3b6d/chrome/browser/subresource_filter/subresource_filter_browser_test_harness.cc
[modify] https://crrev.com/a9f882c736eb48d8cefc4e42566af4ddbb7b3b6d/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
[add] https://crrev.com/a9f882c736eb48d8cefc4e42566af4ddbb7b3b6d/chrome/browser/subresource_filter/subresource_filter_intercepting_browsertest.cc
[modify] https://crrev.com/a9f882c736eb48d8cefc4e42566af4ddbb7b3b6d/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker_browsertest.cc
[modify] https://crrev.com/a9f882c736eb48d8cefc4e42566af4ddbb7b3b6d/chrome/test/BUILD.gn
[modify] https://crrev.com/a9f882c736eb48d8cefc4e42566af4ddbb7b3b6d/components/safe_browsing/db/v4_test_util.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7aede3dfb938e2e451b3d2c044dd3fe46e331de3

commit 7aede3dfb938e2e451b3d2c044dd3fe46e331de3
Author: Charles Harrison <csharrison@chromium.org>
Date: Tue Feb 13 14:47:48 2018

[subresource_filter] Enable Better Ads filtering by default

This enables both the filtering on better ads violating sites, and
also the feature which turns on the "Ads" setting.

Note that we still only sync the SUBRESOURCE_FILTER threat type
on chrome branded builds.

Bug:  737201 
Change-Id: Icafe2d5ae1e995d18668a29ed5c3b9fca6fd20f4
Reviewed-on: https://chromium-review.googlesource.com/910669
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536355}
[modify] https://crrev.com/7aede3dfb938e2e451b3d2c044dd3fe46e331de3/chrome/browser/subresource_filter/subresource_filter_content_settings_manager_unittest.cc
[modify] https://crrev.com/7aede3dfb938e2e451b3d2c044dd3fe46e331de3/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc
[modify] https://crrev.com/7aede3dfb938e2e451b3d2c044dd3fe46e331de3/components/subresource_filter/core/browser/subresource_filter_features.cc
[modify] https://crrev.com/7aede3dfb938e2e451b3d2c044dd3fe46e331de3/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc