Issue metadata
Sign in to add a comment
|
OfflineAudioContext constructor with dictionary |
||||||||||||||||||||||||||||||||||||||||||
Issue descriptionThere is an accepted proposal[1] to the spec[2] that adds a new constructor for OfflineAudioContext that takes a single dictionary argument instead of the three separate numbers. Implement this. [1] https://github.com/WebAudio/web-audio-api/issues/1152 [2] https://github.com/WebAudio/web-audio-api/pull/1264
,
Jul 17 2017
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/096f91f3c998aac2e1e4efcb24eb279b18e54829 commit 096f91f3c998aac2e1e4efcb24eb279b18e54829 Author: Raymond Toy <rtoy@chromium.org> Date: Wed Jul 26 20:49:23 2017 Add dictionary for OfflineAudioContext constructor To make the OfflineAudioContext constructor consistent with the other constructors, a new constructor is defined which takes a single dictionary as the argument. Spec: https://webaudio.github.io/web-audio-api/#OfflineAudioContext Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/hJp_NZU9MiI/yo9kLDJVCAAJ Feature: https://www.chromestatus.com/feature/5635820090294272 BUG= 737200 TEST=constructor/offlineaudiocontext.html Change-Id: Ifb07b3631ac267c58f741097d590487c78eba71f Reviewed-on: https://chromium-review.googlesource.com/583468 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#489750} [add] https://crrev.com/096f91f3c998aac2e1e4efcb24eb279b18e54829/third_party/WebKit/LayoutTests/webaudio/constructor/offlineaudiocontext.html [modify] https://crrev.com/096f91f3c998aac2e1e4efcb24eb279b18e54829/third_party/WebKit/Source/modules/modules_idl_files.gni [modify] https://crrev.com/096f91f3c998aac2e1e4efcb24eb279b18e54829/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp [modify] https://crrev.com/096f91f3c998aac2e1e4efcb24eb279b18e54829/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.h [modify] https://crrev.com/096f91f3c998aac2e1e4efcb24eb279b18e54829/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.idl [add] https://crrev.com/096f91f3c998aac2e1e4efcb24eb279b18e54829/third_party/WebKit/Source/modules/webaudio/OfflineAudioContextOptions.idl
,
Jul 28 2017
|
|||||||||||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||||||||||||||||
Comment 1 by rtoy@chromium.org
, Jul 17 2017