VR: Test input and navigation to/from Native Pages like the NTP |
||||||||
Issue descriptionIn order to prevent regressions like issue 737167 , we should have some tests for navigation and input while viewing a NativePage like the NTP. We already test these things for normal pages, but NativePages have a number of differences in implementation that should be tested.
,
Jul 7 2017
,
Oct 20 2017
bsheedy: Please provide an update on this.
,
Oct 20 2017
The linked issue in the description should be easy to add a regression test for (from what I can tell, it just involves navigating to a native page and tapping on the screen?). What are other specific tests are desired? Just navigating to/from native pages?
,
Oct 20 2017
Yeah, navigating to/from a native page, tapping, and scrolling should be sufficient.
,
Oct 20 2017
Scrolling will have to wait ( Issue 696566 and Issue 749714 imply that scrolling still doesn't work on native pages), but I'll get tests in for the other two cases.
,
Oct 20 2017
Thanks!
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/355d9bbd8dc073a13b545ab20f77b697a949d378 commit 355d9bbd8dc073a13b545ab20f77b697a949d378 Author: bsheedy <bsheedy@chromium.org> Date: Mon Oct 23 17:32:29 2017 Add VR native page navigation and interaction test Adds a VR instrumentation to make sure there aren't any issues navigating to/from native pages or when the screen is tapped while on a native page. Bug: 737168 Change-Id: I1da8093826af8e86cf68b2235a269bb34f5fd9cf Reviewed-on: https://chromium-review.googlesource.com/731645 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#510835} [modify] https://crrev.com/355d9bbd8dc073a13b545ab20f77b697a949d378/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java
,
Dec 13 2017
Issue 737185 has been merged into this issue.
,
Jan 8 2018
Punting to M-65 and blocking on Issue 696566 since the last remaining part of this bug (scrolling on native pages) can't be done until scrolling actually works on native pages.
,
Feb 24 2018
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f94f82d9da9079df7ed54ccc396549b7a1806fd1 commit f94f82d9da9079df7ed54ccc396549b7a1806fd1 Author: bsheedy <bsheedy@chromium.org> Date: Tue Mar 13 17:16:59 2018 Add VR NativePage scroll test Adds VrShellControllerInputTest#testControllerScrollingNative, which ensures that scrolling via the Daydream controller works on the chrome://history NativePage. Bug: 737168 Change-Id: Idfa83286ee56a4c245634e64dc3d80a3ef0a8d43 Reviewed-on: https://chromium-review.googlesource.com/959609 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#542834} [modify] https://crrev.com/f94f82d9da9079df7ed54ccc396549b7a1806fd1/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java [modify] https://crrev.com/f94f82d9da9079df7ed54ccc396549b7a1806fd1/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java [modify] https://crrev.com/f94f82d9da9079df7ed54ccc396549b7a1806fd1/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellControllerInputTest.java
,
Mar 14 2018
,
Mar 16 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mthiesse@chromium.org
, Jun 27 2017