Issue 737160 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ imch...@chromium.org Last visit > 30 days ago
Closed:	Jul 2017
Cc:	mfo...@chromium.org btolsch@chromium.org powerb@chromium.org
Components:	Blink>PresentationAPI
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug
Hotlist-Fixit-PE2017

[Media Router] Presentation ID + URL -> PresentationInfo

Project Member Reported by imch...@chromium.org, Jun 27 2017

Issue description

There are several places in Media Router codebase where a method takes a presentation ID and presentation URL as input parameters. This pattern could be replaced with a single parameter of PresentationInfo, and should make sense for most occurrences (to be extra safe we should evaluate on a case by case basis).

Comment 1 by imch...@chromium.org, Jun 30 2017

Owner: imch...@chromium.org
Status: Started (was: Available)

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e5dc58f0e1c227524b2181232f01041a77603e3

commit 7e5dc58f0e1c227524b2181232f01041a77603e3
Author: imcheng <imcheng@chromium.org>
Date: Fri Jul 07 02:05:27 2017

[Media Router] Clean up OffscreenPresentationManager params.

Presentation ID + URL -> content::PresentationInfo
Also clean up class comments on usage.

BUG= 737160 

Review-Url: https://codereview.chromium.org/2962623002
Cr-Commit-Position: refs/heads/master@{#484791}

[modify] https://crrev.com/7e5dc58f0e1c227524b2181232f01041a77603e3/chrome/browser/media/router/offscreen_presentation_manager.cc
[modify] https://crrev.com/7e5dc58f0e1c227524b2181232f01041a77603e3/chrome/browser/media/router/offscreen_presentation_manager.h
[modify] https://crrev.com/7e5dc58f0e1c227524b2181232f01041a77603e3/chrome/browser/media/router/offscreen_presentation_manager_unittest.cc
[modify] https://crrev.com/7e5dc58f0e1c227524b2181232f01041a77603e3/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/7e5dc58f0e1c227524b2181232f01041a77603e3/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/7e5dc58f0e1c227524b2181232f01041a77603e3/chrome/browser/media/router/receiver_presentation_service_delegate_impl.cc

Comment 3 by imch...@chromium.org, Jul 11 2017

Status: Fixed (was: Started)

►

Issue 737160 link

Issue metadata

[Media Router] Presentation ID + URL -> PresentationInfo

Issue description

Comment 1 by imch...@chromium.org, Jun 30 2017

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Jul 7 2017

Comment 2 Deleted

Comment 3 by imch...@chromium.org, Jul 11 2017

Comment 3 Deleted

Sign in to add a comment